-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use server-side space template logic #10644
Comments
@kobergj can you add a user story or is it tech dept? |
I would say it is technical debt. That is why I added that label. But maybe webbies don't agree? cc @JammingBen (just to mention anyone from web team 😉 ) |
I agree that it's a technical debt 👍 There is no direct value for an end-user, however, much so for us devs. |
While I don't see it coming at the moment that other clients will allow users to create spaces, this is an awesome improvement for the web client alone. Agreeing that it's technical debt, but it also improves server load (less requests is always a good thing). Nice 💪 |
Wonderful 😍 we need to check how we can set the template when the space already exists. (Somebody could have removed the .space folder) |
Fixed via #10656 |
Currently when creating a space, the webclient will fire several requests:
POST
to create the driveMKCOL
to create the.space
folderPROPFIND
to find the id of the.space
folderPUT
to upload thereadme.md
PROPFIND
to find the id of thereadme.md
PATCH
to patch the drive with the special id of thereadme.md
Since owncloud/ocis#8558 the server is able to do all this work for the client(s)
The improved requests would look like this:
POST
to create the drive, add the parameter "template=default"This will create the drive, the
.space
folder, thereadme.md
and a default space image.A benefit of this approach is that other clients can reuse this logic when they want to create spaces. This will lead to a consistent behaviour between all clients.
The text was updated successfully, but these errors were encountered: