-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only] add API test coverage for trying to search with invalid pattern #8441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saw-jan
commented
Feb 13, 2024
Comment on lines
-21
to
-24
Scenario Outline: user can find data from the project space | ||
Given using <dav-path-version> DAV path | ||
When user "Alice" searches for "*fol*" using the WebDAV API | ||
Then the HTTP status code should be "207" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should cover by the scenario below
saw-jan
commented
Feb 13, 2024
Given using <dav-path-version> DAV path | ||
And user "Alice" has created a share inside of space "find data" with settings: | ||
And user "Alice" has created a share inside of space "project101" with settings: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for clarity
3 tasks
saw-jan
force-pushed
the
tests/test-coverage-7815
branch
from
February 13, 2024 10:14
919e393
to
31d5d60
Compare
saw-jan
requested review from
grgprarup,
SagarGi,
PrajwolAmatya and
ScharfViktor
February 13, 2024 10:14
saw-jan
force-pushed
the
tests/test-coverage-7815
branch
from
February 14, 2024 04:02
31d5d60
to
acbe3b2
Compare
Quality Gate passedIssues Measures |
PrajwolAmatya
approved these changes
Feb 14, 2024
ownclouders
pushed a commit
that referenced
this pull request
Feb 14, 2024
…pattern (#8441) * test(api): test coverage for invalid search pattern * test(api): fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added API test coverage for trying to search items with invalid search pattern.
400
statuscodeRelated Issue
Part of #8440
Coverage for:
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: