Search request with scope and empty term fails with http 500

[kulmann]

Describe the bug

Upon debugging owncloud/web#9970 we found out, that:

1. a search query without term, with some filter (e.g. mediatype) and without scope works ✅
2. a search query without term, with some filter (e.g. mediatype) and with scope doesn't work 💥

Steps to reproduce

1. Do a REPORT on /remote.php/dav/spaces with a search pattern like this (scope:... AND mediatype:...).

<oc:pattern>scope:05828167-cf1b-4ea3-b5aa-3159e1b96a60$9e474e92-51ef-48c6-a75b-d12db7a99355!59185db9-8d7f-4aa9-b162-0b8ca8fd7c67 AND mediatype:(&quot;document&quot;)</oc:pattern>

Expected behavior

Like with a search request without the scope I'd expect to have a valid search response.

Actual behavior

http 500 💥

Setup

ownCloud Web UI 8.0.0-alpha.10
Infinite Scale 5.0.0-alpha.3+ed46fa914 Community

[kulmann]

@tbsbdr @micbar p3 fine or different priority?

[2403905]

The error happens because the scope looks like a Property but it is not a part of the search KQL expression. We extract the scope in the beginning of the search service.go#L97
And the KQL expression becomes AND mediatype:("document") with is invalid.
The response need to be fixed, it should be changed to 400.
Please use scope at the beginning or at the end of the search query and omit AND.

[2403905]

The error happens because the scope looks like a Property but it is not a part of the search KQL expression. We extract the scope in the beginning of the search service.go#L97 And the KQL expression becomes AND mediatype:("document") with is invalid. The response need to be fixed, it should be changed to 400. Please use scope at the beginning or at the end of the search query and omit AND.

@kulmann Are you okay with it or do I need to rework it?

[kulmann]

@kulmann Are you okay with it or do I need to rework it?

Sounds good to me - asked in the web issue if the dev who's working on it could try that out. Will come back with feedback as soon as it was tested. :-)

[micbar]

@2403905 was that fixed already?

[kulmann]

There was no fix necessary in ocis. Web fixed the search behaviour using what's already there in the backend 👍