Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 820 - race condition #835

Merged
merged 1 commit into from
Nov 10, 2020
Merged

fix 820 - race condition #835

merged 1 commit into from
Nov 10, 2020

Conversation

butonic
Copy link
Member

@butonic butonic commented Nov 10, 2020 •
edited
Loading

The go routines cause a race condition that sometimes causes the tests to fail. The ListRoles request would not return all permissions.

@butonic
fix 820 - race condition
0c6e888 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@refs refs mentioned this pull request Nov 10, 2020
Closed
@kulmann kulmann merged commit ad3ecbd into owncloud:master Nov 10, 2020
ownclouders pushed a commit that referenced this pull request Nov 10, 2020
@kulmann
commit ad3ecbd
e4fc44f 
Merge: f16c6ea 0c6e888
Author: Benedikt Kulmann <[email protected]>
Date:   Tue Nov 10 15:48:27 2020 +0100

    Merge pull request #835 from butonic/fix-820

    fix 820 - race condition
@dpakach dpakach mentioned this pull request Nov 11, 2020
Closed
@butonic butonic deleted the fix-820 branch November 17, 2020 14:10
@micbar micbar mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refs refs refs approved these changes

@kulmann kulmann kulmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@butonic @kulmann @refs