Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci debug #825

Closed
wants to merge 2 commits into from
Closed

ci debug #825

wants to merge 2 commits into from

Conversation

dpakach
Copy link
Contributor

@dpakach dpakach commented Nov 9, 2020

No description provided.

@update-docs
Copy link

update-docs bot commented Nov 9, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dpakach dpakach force-pushed the ci-debug branch 6 times, most recently from cccb1f9 to f459a43 Compare November 9, 2020 13:23
@butonic
Copy link
Member

butonic commented Nov 9, 2020 •
edited
Loading

@dpakach AFAICT the tests are failing because they are expected to fail, but the actually work (uploads work). I did not find a failure related to ListAccounts permissions ...

@dpakach
Copy link
Contributor Author

dpakach commented Nov 10, 2020

Issue reproduced in the pipeline https://drone.owncloud.com/owncloud/ocis/1308/19/5

@refs
Copy link
Member

refs commented Nov 10, 2020 •
edited
Loading

@dpakach we cherry picked 6c9005e into this and were not able to reproduce the failure anymore. We opened a PR (#835) and are waiting for CI to end.

dpakach and others added 2 commits November 10, 2020 20:19
@dpakach
ci debug
8c1dcc1
@butonic @dpakach
fix 820 - race condition
14e00f3 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@dpakach
Copy link
Contributor Author

dpakach commented Nov 10, 2020

@refs That's really cool. Thanks a lot.
I will rerun it again just to make sure. @phil-davis fixed the bash scripts in core so we shouldn't have the red CI this time.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dpakach
Copy link
Contributor Author

dpakach commented Nov 10, 2020 •
edited
Loading

fixed with #835

@dpakach dpakach closed this Nov 10, 2020
@dpakach dpakach deleted the ci-debug branch January 25, 2021 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj Awaiting requested review from kobergj kobergj will be requested when the pull request is marked ready for review kobergj is a code owner

@phil-davis phil-davis Awaiting requested review from phil-davis phil-davis will be requested when the pull request is marked ready for review phil-davis is a code owner

@individual-it individual-it Awaiting requested review from individual-it individual-it will be requested when the pull request is marked ready for review individual-it is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dpakach @butonic @refs