Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] [tests-only] Added test for sending share invitation to disabled user #8139

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

grgprarup
Copy link
Contributor

Description

Scenarios Added:

  • Scenario Outline: send share invitation to disabled user

Related Issue

How Has This Been Tested?

  • Locally
  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@grgprarup grgprarup self-assigned this Jan 5, 2024
@grgprarup grgprarup force-pushed the add-test-for-invite-disabled-user branch from 8e05f65 to e9771dd Compare January 10, 2024 09:00
@grgprarup grgprarup changed the title [full-ci] [tests-only] Add test to send share invitation disabled user [full-ci] [tests-only] Add test to send share invitation to disabled user Jan 10, 2024
@grgprarup grgprarup changed the title [full-ci] [tests-only] Add test to send share invitation to disabled user [full-ci] [tests-only] Add test for sending share invitation to disabled user Jan 10, 2024
@grgprarup grgprarup changed the title [full-ci] [tests-only] Add test for sending share invitation to disabled user [full-ci] [tests-only] Added test for sending share invitation to disabled user Jan 10, 2024
@grgprarup grgprarup force-pushed the add-test-for-invite-disabled-user branch 2 times, most recently from 888023b to 5ff4b46 Compare January 10, 2024 09:11
| sharee | Brian |
| shareType | user |
| permissionsRole | <permissions-role> |
Then the HTTP status code should be "200"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: We can share with disabled users. #7962 (comment)

@@ -276,7 +276,7 @@ Feature: add users to group
Given these groups have been created:
| groupname | comment |
| sales | normal group |
And the user "Admin" has disabled user "Alice" using the Graph API
And the user "Admin" has disabled user "Alice"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactored as we discussed, we are not using texts like using the Graph API for a given step.

@grgprarup grgprarup force-pushed the add-test-for-invite-disabled-user branch from 5ff4b46 to 62baed3 Compare January 10, 2024 09:20
| Co Owner | folder | FolderToShare |
| Uploader | folder | FolderToShare |
| Manager | folder | FolderToShare |
| permissions-role | resource-type | path |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: kebab-case for example table heading.

@grgprarup grgprarup marked this pull request as ready for review January 10, 2024 09:22
@grgprarup grgprarup force-pushed the add-test-for-invite-disabled-user branch from 62baed3 to 72fa0cd Compare January 11, 2024 04:12
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@grgprarup grgprarup merged commit 3f365b0 into stable-5.0 Jan 11, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the add-test-for-invite-disabled-user branch January 11, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants