Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Added test for banned password to create public link #8194

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Jan 15, 2024

Description

This PR adds following scenarios (creating link shares (public) to banned password):

Scenario Outline: create a file's link share with a password that is listed in the Banned-Password-List
Scenario Outline: update a file's link share with a password that is listed in the Banned-Password-List

Related Issues:

#7968

@SagarGi SagarGi self-assigned this Jan 15, 2024
@SagarGi SagarGi force-pushed the setBannedPassword branch 2 times, most recently from 14a3ae1 to 76a4aae Compare January 16, 2024 06:59
@SagarGi SagarGi marked this pull request as ready for review January 16, 2024 07:01
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other lgtm

tests/acceptance/features/apiSharingNg/linkShare.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiSharingNg/linkShare.feature Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit 7f85df5 into stable-5.0 Jan 18, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the setBannedPassword branch January 18, 2024 11:00
ownclouders pushed a commit that referenced this pull request Jan 18, 2024
…link (#8194)

* Added test for banned password to create public link

Signed-off-by: [email protected] <[email protected]>

* review address

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>
SagarGi added a commit that referenced this pull request Jan 18, 2024
…link (#8194)

* Added test for banned password to create public link

Signed-off-by: [email protected] <[email protected]>

* review address

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>
SagarGi added a commit that referenced this pull request Jan 19, 2024
…8245)

* [tests-only][full-ci]Added test for banned password to create public link (#8194)

* Added test for banned password to create public link

Signed-off-by: [email protected] <[email protected]>

* review address

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>

* [tests-only][full-ci]Added type internal for share link (public) (#8210)

* Added type internal for share link (public)

Signed-off-by: [email protected] <[email protected]>

* fix Ci fail

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>
ownclouders pushed a commit that referenced this pull request Jan 19, 2024
…8245)

* [tests-only][full-ci]Added test for banned password to create public link (#8194)

* Added test for banned password to create public link

Signed-off-by: [email protected] <[email protected]>

* review address

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>

* [tests-only][full-ci]Added type internal for share link (public) (#8210)

* Added type internal for share link (public)

Signed-off-by: [email protected] <[email protected]>

* fix Ci fail

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>

---------

Signed-off-by: [email protected] <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants