Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] Extend API test coverage for replacing file with zero-byte file via TUS upload #8105

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Jan 2, 2024

Description

This PR extends the API test coverage for replacing file with zero-byte file via TUS upload

Added scenarios:

Scenario Outline: upload a zero-byte file in a shared folder
Scenario: upload a zero-byte file in a shared folder (spaces dav path)
Scenario: upload a zero-byte file in a project space
Scenario Outline: replace a shared file with zero-byte file
Scenario: replace a shared file with zero-byte file (spaces dav path)
Scenario: replace a file inside a project space with zero-byte file
Scenario: replace a file inside a shared project space with zero-byte file
Scenario Outline: upload a zero-byte file
Scenario Outline: replace a file with zero-byte file
Scenario Outline: replace a file inside a folder with zero-byte file

Related Issue

Closes #8044

Motivation and Context

Test coverage for bug fix

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan
Copy link
Member Author

saw-jan commented Jan 2, 2024

Blocked until #8003 is fixed. But reviews are welcome

@Salipa-Gurung

This comment was marked as outdated.

@saw-jan saw-jan changed the base branch from stable-5.0 to master January 22, 2024 10:45
@saw-jan saw-jan force-pushed the tests/upload-empty-file-coverage branch from 0a1b18b to 0d51d87 Compare January 22, 2024 10:46
@saw-jan saw-jan force-pushed the tests/upload-empty-file-coverage branch from 0d51d87 to 09ff67b Compare January 22, 2024 10:48
@saw-jan saw-jan requested review from SagarGi and Salipa-Gurung and removed request for lookacat, phil-davis, individual-it, kulmann, micbar and wkloucek January 22, 2024 10:48
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan merged commit cb0090e into master Jan 22, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/upload-empty-file-coverage branch January 22, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] Check and add the API test coverage for updating with empty content/file
4 participants