Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oCIS] Cannot sync file to the server when content is updated to empty content #8003

Closed
2 tasks done
Salipa-Gurung opened this issue Dec 18, 2023 · 6 comments
Closed
2 tasks done
Assignees
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug

Comments

@Salipa-Gurung
Copy link
Contributor

Salipa-Gurung commented Dec 18, 2023

Pre-submission Checks

  • I checked for similar issues, but could not find any. I also checked the closed issues. I could not contribute additional information to any existing issue.
  • I will take the time to fill in all the required fields. I know that the bug report may be dismissed otherwise due to lack of information.

Describe the bug

Desktop client cannot sync the file when the file is updated to have empty content.
From #7940 (comment)

Expected behavior

Updated empty file should be synced to the server.

Steps to reproduce the issue

  1. create a new text file with some content in the server
  2. add that account to the client
  3. from desktop client, update that file to have empty content and save
  4. wait for sync

Screenshots

Screenshot from 2023-12-18 17-39-06

Logs

ownCloud.log

Client version number

ownCloud 5.2.0.12726 f6cca1
Libraries Qt 6.4.3, OpenSSL 3.1.2 1 Aug 2023
Using virtual files plugin: wincfapi
OS: windows-10.0.19045
QPA: windows

Desktop environment (Linux only)

No response

Client package version and origin (Linux only)

No response

Installation path (Windows only)

No response

Server information

Infinite Scale 5.0.0-beta.1 Community

Additional context

No response

@Salipa-Gurung Salipa-Gurung mentioned this issue Dec 18, 2023
71 tasks
@michaelstingl
Copy link
Contributor

500 server error? Move to oCIS repo?

@ScharfViktor
Copy link
Contributor

I could reproduce on server

  • admin creates file new.txt with content
  • admin uploads empty file new.txt using replace

Actual: 500 error. ocisLog:
2023-12-18T14:46:02+01:00 ERR error touching file name=com.owncloud.web.ocdav path=/ request-id=875ae3f6-91a1-499c-b071-cf153d28330c service=ocdav spaceid=1a4ae7f8-f0d0-4d44-9bfc-1c5aec80c09a$80d83e72-2c7a-49d5-88b4-092e968948e3 status={"code":7,"message":"touch file: error: already exists: 8afd09d8-699b-447d-a084-a4fcdf652335","trace":"00000000000000000000000000000000"} traceid=00000000000000000000000000000000

Screen.Recording.2023-12-18.at.14.45.49.mov

@ScharfViktor ScharfViktor transferred this issue from owncloud/client Dec 18, 2023
@ScharfViktor ScharfViktor moved this from Qualification to Prio 2 in Infinite Scale Team Board Dec 20, 2023
@micbar
Copy link
Contributor

micbar commented Dec 20, 2023

Confirmed that this is a bug. Needs fixing.

@micbar micbar added the Priority:p2-high Escalation, on top of current planning, release blocker label Dec 20, 2023
@aduffeck aduffeck self-assigned this Dec 20, 2023
@aduffeck aduffeck moved this from Prio 2 to In progress in Infinite Scale Team Board Dec 20, 2023
aduffeck added a commit to aduffeck/reva that referenced this issue Dec 20, 2023
@saw-jan
Copy link
Member

saw-jan commented Dec 22, 2023

Retested with the latest master. The 500 error seems to be fixed but there's another problem.
Replacing existing file with empty file gives 201 but the previous file content is still there ❌

Web:

Screenshot from 2023-12-22 10-01-46 Screenshot from 2023-12-22 10-02-04
Screenshot from 2023-12-22 10-02-46 Screenshot from 2023-12-22 10-03-27

Desktop client: file content is empty in the file explorer but in the web there is content (adding new sync connection syncs the file content)

Screenshot from 2023-12-22 10-07-30 Screenshot from 2023-12-22 10-08-08
Screenshot from 2023-12-22 10-08-38 Screenshot from 2023-12-22 10-08-58

CC @aduffeck

@aduffeck
Copy link
Contributor

@saw-jan yes, I can reproduce the problem. Seems to be a bug in a different part of the stack. looking into it

@aduffeck
Copy link
Contributor

Fixed by cs3org/reva#4448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:p2-high Escalation, on top of current planning, release blocker Type:Bug
Projects
Archived in project
Development

No branches or pull requests

6 participants