Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] skip sharing tests in reva #7591

Merged
merged 6 commits into from
Oct 27, 2023
Merged

[tests-only] skip sharing tests in reva #7591

merged 6 commits into from
Oct 27, 2023

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Oct 26, 2023 •
edited
Loading

Description

cs3org/reva#4269 (comment)

After talking to kobergj, we decided to skip all failed tests related to auto accepts in reva, auto accepts is an ocis feature and we cannot use it in reva. please use @skipOnReva.

Related Issue

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this Oct 26, 2023
@saw-jan saw-jan force-pushed the tests/skip-shares-reva branch from 39cd549 to cba5f35 Compare October 26, 2023 10:16
@saw-jan saw-jan mentioned this pull request Oct 26, 2023
Merged
@saw-jan saw-jan force-pushed the tests/skip-shares-reva branch from 0c2e1ad to af281ce Compare October 27, 2023 04:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan marked this pull request as ready for review October 27, 2023 06:29
@saw-jan saw-jan merged commit 8eb7f7a into master Oct 27, 2023
1 check passed
@delete-merged-branch delete-merged-branch bot deleted the tests/skip-shares-reva branch October 27, 2023 06:52
ownclouders pushed a commit that referenced this pull request Oct 27, 2023
@saw-jan
[tests-only] skip sharing tests in reva (#7591)
3e0caaf 
* do not use spacesContext

* skip sharing tests in reva

* update expected failure list

* do not cleanup status codes

* skip shares tests in reva

* update expected failure list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saw-jan @ScharfViktor