Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Bump ocis commit id for tests #4269

Closed

Conversation

SwikritiT
Copy link
Contributor

This PR bumps ocis commit id for tests
Part of: owncloud/QA#834

Verified

This commit was signed with the committer’s verified signature.
SwikritiT Swikriti
@SwikritiT SwikritiT requested review from labkode, ishank011, glpatcern and a team as code owners October 19, 2023 11:05
@update-docs
Copy link

update-docs bot commented Oct 19, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@SwikritiT SwikritiT changed the title [test-only][full-ci]Bump ocis commit id for tests [tests-only][full-ci]Bump ocis commit id for tests Oct 19, 2023
@SwikritiT
Copy link
Contributor Author

SwikritiT commented Oct 20, 2023

All the tests failing in CI is because we removed the step to accept the share in ocis (as ocis auto accepts shares now) in PR owncloud/ocis#7477 but in reva the shares need to be accepted. So, we either need to revert those changes and add some logic to only accept shares when the tests are running in reva or skip those tests for reva(which i don't think is ideal)

@ScharfViktor
Copy link

ScharfViktor commented Oct 20, 2023

All the tests failing in CI is because we removed the step to accept the share in ocis (as ocis auto accepts shares now) in PR owncloud/ocis#7477 but in reva the shares need to be accepted. So, we either need to revert those changes and add some logic to only accept shares when the tests are running in reva or skip those tests for reva(which i don't think is ideal)

After talking to @kobergj, we decided to skip all failed tests related to auto accepts in reva, auto accepts is an ocis feature and we cannot use it in reva. please use @skipOnReva.

cc @saw-jan

@SwikritiT
Copy link
Contributor Author

All the tests failing in CI is because we removed the step to accept the share in ocis (as ocis auto accepts shares now) in PR owncloud/ocis#7477 but in reva the shares need to be accepted. So, we either need to revert those changes and add some logic to only accept shares when the tests are running in reva or skip those tests for reva(which i don't think is ideal)

After talking to @kobergj, we decided to skip all failed tests related to auto accepts in reva, auto accepts is an ocis feature and we cannot use it in reva. please use @skipOnReva.

cc @saw-jan

I'm closing this PR @saw-jan can skip the tests and create new PR for ID bump

@SwikritiT SwikritiT closed this Oct 20, 2023
@SwikritiT SwikritiT deleted the tests/bump-commit-id-20231019 branch October 20, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants