[tests-only] [full-ci] removing the setresponse in given/then step in publicwebdav context #7439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6 tasks
KarunAtreya
requested review from
SwikritiT,
SagarGi,
saw-jan,
Salipa-Gurung,
amrita-shrestha,
S-Panta,
PrajwolAmatya,
grgprarup,
nabim777 and
nirajacharya2
saw-jan
reviewed
Oct 10, 2023
tests/acceptance/features/apiSpaces/editPublicLinkOfSpace.feature
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
Oct 10, 2023
tests/acceptance/features/apiSpacesShares/shareSpacesViaLink.feature
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
Oct 10, 2023
tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShare.feature
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
Oct 10, 2023
tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShare.feature
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
Oct 10, 2023
tests/acceptance/features/coreApiSharePublicLink2/reShareAsPublicLinkToSharesNewDav.feature
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
Oct 10, 2023
saw-jan
reviewed
Oct 10, 2023
KarunAtreya
force-pushed
the
refactor_publicwebdav_context
branch
2 times, most recently
from
e953897 to
a57c45d
Compare
saw-jan
reviewed
Oct 11, 2023
tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShare.feature
Show resolved
Hide resolved
saw-jan
reviewed
Oct 11, 2023
tests/acceptance/features/coreApiSharePublicLink1/createPublicLinkShare.feature
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
Oct 11, 2023
saw-jan
reviewed
Oct 11, 2023
KarunAtreya
force-pushed
the
refactor_publicwebdav_context
branch
from
a57c45d to
e1d0db4
Compare
KarunAtreya
force-pushed
the
refactor_publicwebdav_context
branch
from
e1d0db4 to
6de2ab4
Compare
KarunAtreya
force-pushed
the
refactor_publicwebdav_context
branch
3 times, most recently
from
83d3625 to
ef50bb7
Compare
KarunAtreya
force-pushed
the
refactor_publicwebdav_context
branch
from
ef50bb7 to
d5055da
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ownclouders
pushed a commit
that referenced
this pull request
Oct 13, 2023
… publicwebdav context (#7439) * refactored given steps * refactored some when stepa * refactored remaining when and then steps * use of when step for the action * changed line no in expected failure * remove and add same kind of steps in the scenario and refactored function names * adressing reviews
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have used setResponse() and $this->response in the Given/Then steps and some helper functions (maybe to reuse existing available methods). But storing responses from Given/Then steps and helper functions is not a good idea because it can lead to a false positive assertion in the Then steps.
So, check the use of setResponse() and $this->response in
So this pr make the above changes in
PublicWebdavContextRelated Issue
#7082
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: