adressing reviews

owncloud · Oct 12, 2023 · e1d0db4 · e1d0db4
1 parent e5a4474
commit e1d0db4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/tests/acceptance/features/apiSpaces/editPublicLinkOfSpace.feature b/tests/acceptance/features/apiSpaces/editPublicLinkOfSpace.feature
@@ -42,7 +42,7 @@ Feature: A manager of the space can edit public link
       | share_type        | public_link           |
       | displayname_owner | %displayname%         |
       | name              | <linkName>            |
-    When the public downloads file "/test.txt" from inside the last public link shared folder using the new public WebDAV API with password "<password>"
+    When the public downloads file "/test.txt" from inside the last public link shared folder with password "<password>" using the new public WebDAV API
     Then the HTTP status code should be "200"
     And the downloaded content should be "some content"
     Examples:

diff --git a/tests/acceptance/features/apiSpacesShares/shareSpacesViaLink.feature b/tests/acceptance/features/apiSpacesShares/shareSpacesViaLink.feature
@@ -36,7 +36,7 @@ Feature: Share spaces via link
       | displayname_owner | %displayname%         |
       | uid_owner         | %username%            |
       | name              | <linkName>            |
-    When the public downloads file "/test.txt" from inside the last public link shared folder using the new public WebDAV API with password "<password>"
+    When the public downloads file "/test.txt" from inside the last public link shared folder with password "<password>" using the new public WebDAV API
     Then the HTTP status code should be "200"
     And the downloaded content should be "some content"
     But the public should not be able to download file "/test.txt" from inside the last public link shared folder using the new public WebDAV API with password "wrong pass"

diff --git a/tests/acceptance/features/bootstrap/PublicWebDavContext.php b/tests/acceptance/features/bootstrap/PublicWebDavContext.php
@@ -242,15 +242,15 @@ public function downloadPublicFileInsideAFolder(string $path, string $publicWebD
 	}
 
 	/**
-	 * @When /^the public downloads file "([^"]*)" from inside the last public link shared folder using the (old|new) public WebDAV API with password "([^"]*)"$/
+	 * @When /^the public downloads file "([^"]*)" from inside the last public link shared folder with password "([^"]*)" using the (old|new) public WebDAV API$/
 	 *
 	 * @param string $path
 	 * @param string $publicWebDAVAPIVersion
 	 * @param string $password
 	 *
 	 * @return void
 	 */
-	public function downloadPublicFileInsideAFolderWithPassword(string $path, string $publicWebDAVAPIVersion = "old", string $password = ""):void {
+	public function publicDownloadsFileFromInsideLastPublicSharedFolderWithPassword(string $path, string $publicWebDAVAPIVersion = "old", string $password = ""):void {
 		$response = $this->downloadFileFromPublicFolder(
 			$path,
 			$password,
@@ -721,13 +721,13 @@ public function checkLastPublicSharedFileWithPasswordDownload(
 			$password
 		);
 
+		$this->featureContext->theHTTPStatusCodeShouldBe(200, "", $response);
+
 		$this->featureContext->checkDownloadedContentMatches(
 			$expectedContent,
 			"Checking the content of the last public shared file after downloading with the $publicWebDAVAPIVersion public WebDAV API",
 			$response
 		);
-
-		$this->featureContext->theHTTPStatusCodeShouldBe(200, "", $response);
 	}
 
 	/**