Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] backport removing the setresponse in given/then step in FileVersions Context #7269

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

KarunAtreya
Copy link
Contributor

Description

This pr backports #7111 to stable-4.0

@KarunAtreya KarunAtreya force-pushed the backport_refactor_fileversions_context branch from 49179c9 to d23e048 Compare September 12, 2023 11:01
migrating set response from helper function to when step in preview feature

separate single when/then steps by converting to helper function

use of httpstatuscode check function in given step and rebased

change function name

remove use of setresponse in then step

set the returned response
@KarunAtreya KarunAtreya force-pushed the backport_refactor_fileversions_context branch from d23e048 to d31feb6 Compare September 13, 2023 09:31
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit 71daf3f into stable-4.0 Sep 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the backport_refactor_fileversions_context branch September 13, 2023 10:39
ownclouders pushed a commit that referenced this pull request Sep 13, 2023
migrating set response from helper function to when step in preview feature

separate single when/then steps by converting to helper function

use of httpstatuscode check function in given step and rebased

change function name

remove use of setresponse in then step

set the returned response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants