-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci] removing the setresponse in given/then step in FileVersionsContext #7111
Conversation
78ca322
to
642e0e5
Compare
44e2143
to
896c984
Compare
ee3ea66
to
eb0bd13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fef922d
to
e95547a
Compare
made some more changes to remove when step used by then step. so can you review again the last two commits @saw-jan @SwikritiT @SagarGi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Refactor LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me
The branch seems to be little bit behind master please rebase and push
https://github.com/owncloud/ocis/tree/refactor_setresponse_ingiventhen_steps
6f87e92
to
47068b3
Compare
5b2f2bf
to
53a6b96
Compare
53a6b96
to
def8f07
Compare
def8f07
to
b042575
Compare
Kudos, SonarCloud Quality Gate passed! |
…FileVersionsContext (#7111) * migrating set response from helper function to when step in preview feature * separate single when/then steps by converting to helper function * use of httpstatuscode check function in given step and rebased * change function name * remove use of setresponse in then step * set the returned response
Description
We have used setResponse() and $this->response in the Given/Then steps and some helper functions (maybe to reuse existing available methods). But storing responses from Given/Then steps and helper functions is not a good idea because it can lead to a false positive assertion in the Then steps.
So, check the use of setResponse() and $this->response in
Related Issue
#7082
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: