[tests-only][full-ci] backport removing the setresponse in given/then step in CheckSumContext and FavoritesContext #7268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarunAtreya
requested review from
grgprarup,
SwikritiT,
SagarGi,
saw-jan and
PrajwolAmatya
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
KarunAtreya
changed the title
KarunAtreya
force-pushed
the
backport_refactor_checksum_and_favorite
branch
from
df4cc8e to
1c680fa
Compare
Closed
6 tasks
saw-jan
approved these changes
Sep 12, 2023
|
the previous build failed because #7169 was not backported |
making helper function, checking and setting response in given step and when steo respectively returning response and using in given/then steps as required in favoritesContext set the returned response on SpaceContext changed to inline variable in some lines as required to check for the specific https response code
KarunAtreya
force-pushed
the
backport_refactor_checksum_and_favorite
branch
from
1c680fa to
c0c55c1
Compare
SwikritiT
approved these changes
Sep 13, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
delete-merged-branch
bot
deleted the
backport_refactor_checksum_and_favorite
branch
ownclouders
pushed a commit
that referenced
this pull request
Sep 14, 2023
…7268) making helper function, checking and setting response in given step and when steo respectively returning response and using in given/then steps as required in favoritesContext set the returned response on SpaceContext changed to inline variable in some lines as required to check for the specific https response code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr backports #7202 to stable 4.0