[tests-only][full-ci] removing the setresponse in given/then step in CheckSumContext and FavoritesContext #7202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarunAtreya
changed the title
KarunAtreya
changed the title
KarunAtreya
force-pushed
the
refactor_settingreponse
branch
from
0d5a721 to
56774ce
Compare
KarunAtreya
requested review from
grgprarup,
SwikritiT,
SagarGi,
saw-jan,
Salipa-Gurung,
S-Panta,
PrajwolAmatya and
nirajacharya2
KarunAtreya
force-pushed
the
refactor_settingreponse
branch
from
b175a18 to
3ed9431
Compare
KarunAtreya
force-pushed
the
refactor_settingreponse
branch
from
3ed9431 to
436b61e
Compare
Closed
6 tasks
SwikritiT
reviewed
Sep 7, 2023
SwikritiT
reviewed
Sep 7, 2023
SwikritiT
reviewed
Sep 7, 2023
SwikritiT
reviewed
Sep 7, 2023
SwikritiT
reviewed
Sep 7, 2023
KarunAtreya
force-pushed
the
refactor_settingreponse
branch
3 times, most recently
from
a790aa2 to
e14c749
Compare
…nd when steo respectively
KarunAtreya
force-pushed
the
refactor_settingreponse
branch
from
e14c749 to
99e02fa
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ownclouders
pushed a commit
that referenced
this pull request
Sep 11, 2023
…CheckSumContext and FavoritesContext (#7202) * making helper function, checking and setting response in given step and when steo respectively * returning response and using in given/then steps as required in favoritesContext * set the returned response on SpaceContext * changed to inline variable in some lines as required * to check for the specific https response code
ownclouders
pushed a commit
that referenced
this pull request
Sep 12, 2023
…CheckSumContext and FavoritesContext (#7202) * making helper function, checking and setting response in given step and when steo respectively * returning response and using in given/then steps as required in favoritesContext * set the returned response on SpaceContext * changed to inline variable in some lines as required * to check for the specific https response code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have used setResponse() and $this->response in the Given/Then steps and some helper functions (maybe to reuse existing available methods). But storing responses from Given/Then steps and helper functions is not a good idea because it can lead to a false positive assertion in the Then steps.
So, check the use of setResponse() and $this->response in
So this pr make the above changes in
CheckSumContext.phpandFavoritesContextRelated Issue
#7082
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: