[tests-only][full-ci]Backport search folder by tag in project space #6996
Conversation
nabim777
requested review from
grgprarup,
SwikritiT,
SagarGi,
saw-jan,
amrita-shrestha and
PrajwolAmatya
| | spaces | | ||
|
|
There was a problem hiding this comment.
Seems like this doesn't work for spaces in stable
Examples:
| dav-path-version |
| old |
| new |
| spaces |
Failed step: And the search result of user "Alice" should contain only these files:
The number of elements in the response doesn't matches with expected number of elements
Failed asserting that 0 matches expected 2.| | spaces | |
There was a problem hiding this comment.
ok I will keep the tag @skipOnStable3.0 on spaces
There was a problem hiding this comment.
@nabim777 does it not work in stable-3.0 or what? it seems to be passing in master isn't it?
There was a problem hiding this comment.
Yes, I think it works for master. I think in this case we can just remove the stable option from the example if it's not supposed to work for stable instead of skipping the whole scenario, but is it supposed to not work for stable? cc @saw-jan
There was a problem hiding this comment.
There was same issue in master also later by adding remote.php in spaces dav endpoint that works fine and passes. But in stable after adding the remote.php it gives 405 status
@nabim777 does it not work in stable-3.0 or what? it seems to be passing in master isn't it?
nabim777
force-pushed
the
backport-search-folder-by-tag-in-Project-space
branch
from
b94b778 to
7f1e40e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
| @skipOnStable3.0 | ||
| Examples: | ||
| | dav-path-version | | ||
| | spaces | | ||
|
|
There was a problem hiding this comment.
Note that this exact change should be made in master as well otherwise, there will be conflict while merging the stable to master. We want as minimal conflicts as possible
delete-merged-branch
bot
deleted the
backport-search-folder-by-tag-in-Project-space
branch
|
@nabim777 please make sure to forward-port the small example-table changes to master. |
…in-Project-space [tests-only][full-ci]Backport search folder by tag in project space
…in-Project-space [tests-only][full-ci]Backport search folder by tag in project space
…in-Project-space [tests-only][full-ci]Backport search folder by tag in project space
…in-Project-space [tests-only][full-ci]Backport search folder by tag in project space
…in-Project-space [tests-only][full-ci]Backport search folder by tag in project space
…in-Project-space [tests-only][full-ci]Backport search folder by tag in project space
…in-Project-space [tests-only][full-ci]Backport search folder by tag in project space
This PR is Backport of master PR #6968