Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]add test for search project folders by tag #6968

Merged
merged 1 commit into from
Aug 8, 2023
Merged

[tests-only][full-ci]add test for search project folders by tag #6968

merged 1 commit into from
Aug 8, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Aug 7, 2023 •
edited
Loading

Description

This PR adds the API tests for full search api. The scenarios added in this PR are

Related Issue

Motivation and Context

  • there was no test coverage for api test for search project space folders using tag. so, this PR covers the require scenario test case

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Aug 7, 2023
@nabim777 nabim777 mentioned this pull request Aug 7, 2023
Closed
51 tasks
@nabim777 nabim777 force-pushed the search-folder-by-tag-in-Project-space branch from afc1086 to ff0885d Compare August 7, 2023 06:50
@nabim777 nabim777 requested a review from SwikritiT August 7, 2023 06:50
saw-jan
saw-jan reviewed Aug 7, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SagarGi SagarGi self-requested a review August 8, 2023 04:06
SagarGi
SagarGi reviewed Aug 8, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

SwikritiT
SwikritiT approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SwikritiT SwikritiT requested a review from SagarGi August 8, 2023 04:16
SwikritiT
SwikritiT suggested changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nabim777 the branch is 15 commits behind master
https://github.com/owncloud/ocis/tree/search-folder-by-tag-in-Project-space
please rebase and push

@nabim777 nabim777 force-pushed the search-folder-by-tag-in-Project-space branch from ff0885d to 465a1c8 Compare August 8, 2023 04:49
@nabim777 nabim777 requested review from saw-jan and SwikritiT August 8, 2023 04:50
@nabim777 nabim777 force-pushed the search-folder-by-tag-in-Project-space branch 3 times, most recently from 2eae31d to 591bbbe Compare August 8, 2023 06:15
@nabim777 nabim777 force-pushed the search-folder-by-tag-in-Project-space branch from 591bbbe to 6600f99 Compare August 8, 2023 06:36
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SagarGi SagarGi merged commit 3093a84 into master Aug 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the search-folder-by-tag-in-Project-space branch August 8, 2023 10:40
ownclouders pushed a commit that referenced this pull request Aug 8, 2023
@nabim777
add test for search project space folders by tag (#6968)
962943a
@nabim777 nabim777 mentioned this pull request Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi approved these changes

@SwikritiT SwikritiT SwikritiT approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nabim777 @SwikritiT @SagarGi @saw-jan