Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test-only]ApiTest. Deprovisioning notification tests #6994

Merged
merged 2 commits into from
Aug 14, 2023
Merged

[test-only]ApiTest. Deprovisioning notification tests #6994

merged 2 commits into from
Aug 14, 2023

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Aug 8, 2023 •
edited by saw-jan
Loading

related: #6672

  • admin creates deprovisioning notification
  • users get deprovisioning notification
  • users get deprovisioning notification in different languages
  • non-admin cannot create deprovisioning notification
  • after reading deprovisioning notification it appears again
  • admin deletes deprovisioning notification -> users don't see notification
  • non-admin cannot delete deprovisioning notification
  • delete deprovisioning notification afterScenario step

tests for next PR:
- [ ] using different data format
- [ ] change notification

Follow up in #7029

@update-docs
Copy link

update-docs bot commented Aug 8, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor changed the title [test-only] ApiTest. Deprovisioning notification tests [test-only][full-ci] ApiTest. Deprovisioning notification tests Aug 9, 2023
@ScharfViktor ScharfViktor changed the title [test-only][full-ci] ApiTest. Deprovisioning notification tests [test-only]ApiTest. Deprovisioning notification tests Aug 9, 2023
@SwikritiT
Copy link
Contributor

I've pushed a commit adding the things that I reviewed and also rebased the PR to the latest master. Rest looks good to me

@saw-jan please review and maybe we can merge this?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT SwikritiT merged commit 0258b2b into master Aug 14, 2023
@delete-merged-branch delete-merged-branch bot deleted the deprovTests branch August 14, 2023 07:16
ownclouders pushed a commit that referenced this pull request Aug 14, 2023
@ScharfViktor @SwikritiT
[test-only]ApiTest. Deprovisioning notification tests (#6994)
4213a33 
* add create/delete notification tests

* fix grammar

---------

Co-authored-by: Swikriti Tripathi <[email protected]>
@saw-jan saw-jan mentioned this pull request Aug 14, 2023
Closed
2 tasks
@nirajacharya2 nirajacharya2 mentioned this pull request Aug 18, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT left review comments

@saw-jan saw-jan saw-jan approved these changes

@individual-it individual-it Awaiting requested review from individual-it

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ScharfViktor @SwikritiT @saw-jan