Deprovisioning Notification #6672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
💥 Acceptance test localApiTests-apiSpacesShares-ocis failed. Further test are cancelled... |
kobergj
force-pushed
the
DeprovisionNotification
branch
2 times, most recently
from
d43d1c8 to
378b4ef
Compare
|
@mmattel mind having a look on readme changes? 🥺 |
kobergj
force-pushed
the
DeprovisionNotification
branch
from
378b4ef to
22ba896
Compare
mmattel
reviewed
Jul 6, 2023
mmattel
reviewed
Jul 6, 2023
mmattel
reviewed
Jul 6, 2023
kobergj
force-pushed
the
DeprovisionNotification
branch
2 times, most recently
from
faa71f3 to
71e5273
Compare
|
@EParzefall mind to have a look on the text changes I made for in depth improvements? |
EParzefall
approved these changes
Jul 6, 2023
Signed-off-by: jkoberg <[email protected]>
Signed-off-by: jkoberg <[email protected]>
Signed-off-by: jkoberg <[email protected]>
Signed-off-by: jkoberg <[email protected]>
kobergj
force-pushed
the
DeprovisionNotification
branch
from
f05e8a4 to
9cf0700
Compare
Signed-off-by: jkoberg <[email protected]>
kobergj
force-pushed
the
DeprovisionNotification
branch
from
9cf0700 to
ff61d25
Compare
|
Kudos, SonarCloud Quality Gate passed! |
dragonchaser
approved these changes
Jul 10, 2023
| @@ -54,6 +54,11 @@ var ( | |||
| Subject: Template("Share expired"), | |||
| Message: Template("Access to {resource} expired"), | |||
| } | |||
|
|
|||
| PlatformDeprovision = NotificationTemplate{ | |||
| Subject: Template("Instance will be shut down and deprovisioned"), | |||
There was a problem hiding this comment.
Shockmessage, should be more softer IMHO like "Instance will be shutdown in %d days|months"
/cc @mmattel
There was a problem hiding this comment.
👍 good point. Will open new PR for it because of the current CI issues
ownclouders
pushed a commit
that referenced
this pull request
Jul 10, 2023
Deprovisioning Notification
This was referenced Jul 11, 2023
8 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds global notifications to userlog service
To store a deprovision notification
POSTon/globalendpoint:curl --insecure -X POST -v -u admin:admin -d '{"type":"deprovision", "data":{"deprovision_date": "2023-07-04T12:23:12Z"}}' https://localhost:9200/ocs/v2.php/apps/notifications/api/v1/notifications/globalYou can define the format of the date with the
deprovision_date_formatparametercurl --insecure -X POST -v -u admin:admin -d '{"type":"deprovision", "data":{"deprovision_date": "2023-07-04 15:17", "deprovision_date_format":"2006-01-02 15:04"}}' https://localhost:9200/ocs/v2.php/apps/notifications/api/v1/notifications/globalSee go time formating for format details
To delete a deprovision notification
DELETEon/globalendpointcurl --insecure -X DELETE -v -u admin:admin -d '{"ids":["deprovision"]}' https://localhost:9200/ocs/v2.php/apps/notifications/api/v1/notifications/globalNOTE: non admin users will only get a
404 NOT FOUNDon both endpoints