Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] added test scenario for searching inside current folder in personal space #6949

Merged
merged 1 commit into from
Aug 7, 2023
Merged

[tests-only][full-ci] added test scenario for searching inside current folder in personal space #6949

merged 1 commit into from
Aug 7, 2023

Conversation

KarunAtreya
Copy link
Contributor

@KarunAtreya KarunAtreya commented Aug 3, 2023 •
edited
Loading

Description

This PR adds Api test for searching inside current folder in personal space(Location Filter). Following scenario is added:

  • search files inside the current folder

Related Issue

#6606

Motivation and Context

There is no test coverage for api test for searching by enabling current folder on where files and folders are searched inside that particular folder only.

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@KarunAtreya KarunAtreya self-assigned this Aug 3, 2023
@KarunAtreya KarunAtreya force-pushed the search-inside-current-folder branch from 6f0744e to 95666b9 Compare August 3, 2023 04:20
@KarunAtreya KarunAtreya mentioned this pull request Aug 2, 2023
Closed
51 tasks
@KarunAtreya KarunAtreya force-pushed the search-inside-current-folder branch 2 times, most recently from af6c2ae to cc8c420 Compare August 3, 2023 06:36
@KarunAtreya KarunAtreya force-pushed the search-inside-current-folder branch 3 times, most recently from ea2f423 to be0909f Compare August 3, 2023 08:42
@saw-jan
Copy link
Member

saw-jan commented Aug 4, 2023

@KarunAtreya Please, rebase

@KarunAtreya KarunAtreya force-pushed the search-inside-current-folder branch 2 times, most recently from ef939db to 54cf1e3 Compare August 4, 2023 08:53
@KarunAtreya KarunAtreya requested a review from saw-jan August 4, 2023 08:56
@KarunAtreya KarunAtreya force-pushed the search-inside-current-folder branch 2 times, most recently from f9eadde to 294c298 Compare August 4, 2023 10:47
@KarunAtreya KarunAtreya force-pushed the search-inside-current-folder branch 2 times, most recently from 2de00b8 to c9180c0 Compare August 4, 2023 11:27
@KarunAtreya KarunAtreya force-pushed the search-inside-current-folder branch from c9180c0 to 55e85d0 Compare August 4, 2023 11:38
saw-jan
saw-jan reviewed Aug 4, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

SwikritiT
SwikritiT reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a small suggestion. it just looks weird to me to have random upper letters in a sentence

tests/acceptance/features/apiGraph/fullSearch.feature Outdated Show resolved Hide resolved
tests/acceptance/features/apiGraph/fullSearch.feature Outdated Show resolved Hide resolved
@KarunAtreya KarunAtreya force-pushed the search-inside-current-folder branch from 55e85d0 to 60bfd5f Compare August 7, 2023 03:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

SwikritiT
SwikritiT approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SwikritiT SwikritiT requested a review from phil-davis August 7, 2023 05:22
@phil-davis phil-davis merged commit 10751ef into master Aug 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the search-inside-current-folder branch August 7, 2023 06:43
ownclouders pushed a commit that referenced this pull request Aug 7, 2023
@phil-davis
Merge pull request #6949 from owncloud/search-inside-current-folder
f3aab0f 
[tests-only][full-ci] added test scenario for searching inside current folder in personal space
@KarunAtreya KarunAtreya mentioned this pull request Aug 8, 2023
Merged
saw-jan pushed a commit that referenced this pull request Aug 8, 2023
@KarunAtreya
[tests-only][full-ci] Backport searching inside folder in personal sp…
49cc773 
…ace(#6949) (#6980)

* added test scenario for searching inside particular folder only

* added skip on stabl3.0
ownclouders pushed a commit that referenced this pull request Aug 8, 2023
@KarunAtreya
[tests-only][full-ci] Backport searching inside folder in personal sp…
c784504 
…ace(#6949) (#6980)

* added test scenario for searching inside particular folder only

* added skip on stabl3.0
@KarunAtreya KarunAtreya mentioned this pull request Aug 9, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nabim777 nabim777 nabim777 left review comments

@saw-jan saw-jan saw-jan approved these changes

@SwikritiT SwikritiT SwikritiT approved these changes

@phil-davis phil-davis phil-davis approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

Assignees

@KarunAtreya KarunAtreya

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@KarunAtreya @saw-jan @phil-davis @SwikritiT @amrita-shrestha @nabim777