Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Backport delete notification tests coverage #6836

Merged
merged 2 commits into from
Jul 18, 2023
Merged

[tests-only][full-ci]Backport delete notification tests coverage #6836

merged 2 commits into from
Jul 18, 2023

Conversation

amrita-shrestha
Copy link
Contributor

Description

This PR backport tests coverage of delete notification and notification

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha self-assigned this Jul 18, 2023
grgprarup
grgprarup approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@amrita-shrestha amrita-shrestha merged commit b88cd12 into stable-3.0 Jul 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the forwardport-delete-notification branch July 18, 2023 10:37
ownclouders pushed a commit that referenced this pull request Jul 18, 2023
@amrita-shrestha
[tests-only][full-ci]Backport delete notification tests coverage (#6836)
f9e74bf 
* Add tests for space notification (#6372)

* Add tests for deleting specific notification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT approved these changes

@grgprarup grgprarup grgprarup approved these changes

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrita-shrestha @grgprarup @SwikritiT