-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]Add tests for deleting notification #6735
Merged
amrita-shrestha
merged 1 commit into
master
from
add-notification-delete-tests-coverage
Jul 18, 2023
Merged
[tests-only][full-ci]Add tests for deleting notification #6735
amrita-shrestha
merged 1 commit into
master
from
add-notification-delete-tests-coverage
Jul 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amrita-shrestha
force-pushed
the
add-notification-delete-tests-coverage
branch
5 times, most recently
from
July 11, 2023 04:39
2fb07b8
to
1bc50b3
Compare
amrita-shrestha
force-pushed
the
add-notification-delete-tests-coverage
branch
from
July 11, 2023 06:49
1bc50b3
to
75047f3
Compare
grgprarup
reviewed
Jul 11, 2023
tests/acceptance/features/apiNotification/deleteNotification.feature
Outdated
Show resolved
Hide resolved
grgprarup
reviewed
Jul 11, 2023
tests/acceptance/features/apiNotification/deleteNotification.feature
Outdated
Show resolved
Hide resolved
grgprarup
reviewed
Jul 11, 2023
tests/acceptance/features/apiNotification/deleteNotification.feature
Outdated
Show resolved
Hide resolved
grgprarup
reviewed
Jul 11, 2023
tests/acceptance/features/apiNotification/deleteNotification.feature
Outdated
Show resolved
Hide resolved
KarunAtreya
reviewed
Jul 11, 2023
amrita-shrestha
force-pushed
the
add-notification-delete-tests-coverage
branch
from
July 11, 2023 11:39
75047f3
to
f506f57
Compare
saw-jan
reviewed
Jul 11, 2023
saw-jan
reviewed
Jul 11, 2023
tests/acceptance/features/apiNotification/deleteNotification.feature
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
Jul 11, 2023
tests/acceptance/features/apiNotification/deleteNotification.feature
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
Jul 11, 2023
tests/acceptance/features/apiNotification/deleteNotification.feature
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
Jul 11, 2023
tests/acceptance/features/apiNotification/deleteNotification.feature
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
Jul 11, 2023
saw-jan
reviewed
Jul 11, 2023
tests/acceptance/features/apiNotification/deleteNotification.feature
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
Jul 11, 2023
tests/acceptance/features/apiNotification/deleteNotification.feature
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
Jul 11, 2023
saw-jan
reviewed
Jul 11, 2023
SwikritiT
reviewed
Jul 12, 2023
amrita-shrestha
force-pushed
the
add-notification-delete-tests-coverage
branch
3 times, most recently
from
July 12, 2023 07:14
0f81835
to
d9ab338
Compare
saw-jan
reviewed
Jul 12, 2023
amrita-shrestha
force-pushed
the
add-notification-delete-tests-coverage
branch
from
July 13, 2023 04:25
d9ab338
to
adcde7e
Compare
SagarGi
reviewed
Jul 13, 2023
amrita-shrestha
force-pushed
the
add-notification-delete-tests-coverage
branch
2 times, most recently
from
July 17, 2023 06:52
92e778a
to
dcbe127
Compare
amrita-shrestha
force-pushed
the
add-notification-delete-tests-coverage
branch
from
July 17, 2023 07:13
dcbe127
to
37b6012
Compare
SwikritiT
reviewed
Jul 17, 2023
saw-jan
reviewed
Jul 17, 2023
tests/acceptance/features/apiNotification/deleteNotification.feature
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
Jul 17, 2023
saw-jan
reviewed
Jul 17, 2023
amrita-shrestha
force-pushed
the
add-notification-delete-tests-coverage
branch
from
July 17, 2023 11:41
37b6012
to
1569da0
Compare
Kudos, SonarCloud Quality Gate passed! |
saw-jan
reviewed
Jul 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Usage of global variables like |
ScharfViktor
approved these changes
Jul 18, 2023
delete-merged-branch
bot
deleted the
add-notification-delete-tests-coverage
branch
July 18, 2023 08:27
ownclouders
pushed a commit
that referenced
this pull request
Jul 18, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds tests coverage for deleting notifcations
Related Issue
How Has This Been Tested?
Types of changes
Checklist: