Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Add tests for deleting notification #6735

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

amrita-shrestha
Copy link
Contributor

Description

This PR adds tests coverage for deleting notifcations

Related Issue

How Has This Been Tested?

  • Locally

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha self-assigned this Jul 6, 2023
@amrita-shrestha amrita-shrestha force-pushed the add-notification-delete-tests-coverage branch 5 times, most recently from 2fb07b8 to 1bc50b3 Compare July 11, 2023 04:39
@amrita-shrestha amrita-shrestha marked this pull request as ready for review July 11, 2023 04:40
@amrita-shrestha amrita-shrestha force-pushed the add-notification-delete-tests-coverage branch from 1bc50b3 to 75047f3 Compare July 11, 2023 06:49
@amrita-shrestha amrita-shrestha force-pushed the add-notification-delete-tests-coverage branch from 75047f3 to f506f57 Compare July 11, 2023 11:39
@amrita-shrestha amrita-shrestha force-pushed the add-notification-delete-tests-coverage branch 3 times, most recently from 0f81835 to d9ab338 Compare July 12, 2023 07:14
@amrita-shrestha amrita-shrestha force-pushed the add-notification-delete-tests-coverage branch from d9ab338 to adcde7e Compare July 13, 2023 04:25
@amrita-shrestha amrita-shrestha force-pushed the add-notification-delete-tests-coverage branch 2 times, most recently from 92e778a to dcbe127 Compare July 17, 2023 06:52
@amrita-shrestha amrita-shrestha requested a review from saw-jan July 17, 2023 06:52
@amrita-shrestha amrita-shrestha force-pushed the add-notification-delete-tests-coverage branch from dcbe127 to 37b6012 Compare July 17, 2023 07:13
@amrita-shrestha amrita-shrestha requested a review from saw-jan July 17, 2023 11:41
@amrita-shrestha amrita-shrestha force-pushed the add-notification-delete-tests-coverage branch from 37b6012 to 1569da0 Compare July 17, 2023 11:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan
Copy link
Member

saw-jan commented Jul 17, 2023

Usage of global variables like notificationsIds can be omitted but I don't know how long this PR will get with that

@amrita-shrestha amrita-shrestha merged commit 70411e6 into master Jul 18, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-notification-delete-tests-coverage branch July 18, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tests coverage for deleting notification
7 participants