Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] added test for mail notification if space admin delete access to space #6719

Merged
merged 1 commit into from
Jul 10, 2023
Merged

[tests-only][full-ci] added test for mail notification if space admin delete access to space #6719

merged 1 commit into from
Jul 10, 2023

Conversation

nirajacharya2
Copy link
Contributor

Description

This PR forward ports #6657

Motivation and Context

How Has This Been Tested?

test environment:

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Jul 5, 2023
@nirajacharya2 nirajacharya2 mentioned this pull request Jul 5, 2023
Merged
10 tasks
SagarGi
SagarGi reviewed Jul 5, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 if CI is happy

@nirajacharya2 nirajacharya2 force-pushed the mail-deleting-acess-space-or-share-master branch 3 times, most recently from 990bf0f to 73498a1 Compare July 5, 2023 07:20
saw-jan
saw-jan approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan requested a review from ScharfViktor July 5, 2023 07:26
@nirajacharya2 nirajacharya2 force-pushed the mail-deleting-acess-space-or-share-master branch from 73498a1 to acc5545 Compare July 10, 2023 05:41
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit db70ab2 into master Jul 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the mail-deleting-acess-space-or-share-master branch July 10, 2023 07:22
ownclouders pushed a commit that referenced this pull request Jul 10, 2023
@nirajacharya2
added test for mail notification if space admin delete access to space (
098f87d 
#6719)
fschade pushed a commit that referenced this pull request Jul 10, 2023
@nirajacharya2 @fschade
added test for mail notification if space admin delete access to space (
d66199f 
#6719)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@saw-jan saw-jan saw-jan approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nirajacharya2 @SagarGi @saw-jan @ScharfViktor