Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] added test for mail notification if space admin delete access to space #6657

Merged
merged 1 commit into from
Jul 4, 2023
Merged

[tests-only][full-ci] added test for mail notification if space admin delete access to space #6657

merged 1 commit into from
Jul 4, 2023

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Jun 28, 2023 •
edited
Loading

Description

This PR adds the API test scenario for mail notification.

  • Scenario: user gets an email notification when space admin unshares a space

Related Issue

Motivation and Context

How Has This Been Tested?

test environment:

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Jun 28, 2023
@nirajacharya2 nirajacharya2 mentioned this pull request Jun 28, 2023
Closed
51 tasks
@SwikritiT SwikritiT marked this pull request as ready for review June 28, 2023 11:40
@nirajacharya2 nirajacharya2 force-pushed the mail-deleting-acess-space-or-share branch from 16e7576 to 8ad0e4b Compare June 29, 2023 07:22
saw-jan
saw-jan approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nirajacharya2 nirajacharya2 force-pushed the mail-deleting-acess-space-or-share branch from 8ad0e4b to 21f570b Compare June 30, 2023 08:10
@nirajacharya2 nirajacharya2 force-pushed the mail-deleting-acess-space-or-share branch from 21f570b to 7c2a363 Compare July 3, 2023 04:01
SwikritiT
SwikritiT approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit ec8b66b into stable-3.0 Jul 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the mail-deleting-acess-space-or-share branch July 4, 2023 11:23
ownclouders pushed a commit that referenced this pull request Jul 4, 2023
@nirajacharya2
added test for mail notification if space admin delete access to space (
c14fbf6 
#6657)
@nirajacharya2 nirajacharya2 mentioned this pull request Jul 5, 2023
Merged
9 tasks
ownclouders pushed a commit that referenced this pull request Jul 8, 2023
@nirajacharya2
added test for mail notification if space admin delete access to space (
19dd13a 
#6657)
ownclouders pushed a commit that referenced this pull request Jul 9, 2023
@nirajacharya2
added test for mail notification if space admin delete access to space (
06e4dbd 
#6657)
ownclouders pushed a commit that referenced this pull request Jul 10, 2023
@nirajacharya2
added test for mail notification if space admin delete access to space (
bcfc6f5 
#6657)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@saw-jan saw-jan saw-jan approved these changes

@SwikritiT SwikritiT SwikritiT approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nirajacharya2 @SwikritiT @SagarGi @saw-jan