Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Add test for search restored files using content #6709

Merged
merged 1 commit into from
Jul 25, 2023
Merged

[tests-only][full-ci]Add test for search restored files using content #6709

merged 1 commit into from
Jul 25, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Jul 4, 2023 •
edited
Loading

Description

This PR adds the API tests for search restored files through a tag. The scenarios added in this PR are

Related Issue

Motivation and Context

  • there was no test coverage for api test for search restored files through a content. so, this PR covers the require scenario test case

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 mentioned this pull request Jul 4, 2023
Closed
51 tasks
@nabim777 nabim777 self-assigned this Jul 4, 2023
@nabim777 nabim777 force-pushed the search-restored-files-using-context branch 3 times, most recently from b88e7f6 to a11b5ec Compare July 18, 2023 05:40
@nabim777 nabim777 marked this pull request as ready for review July 18, 2023 05:41
This was referenced Jul 18, 2023
Merged
Merged
@nabim777 nabim777 changed the title [tests-only][full-ci]Search restored files using context [tests-only][full-ci]Add test for search restored files using context Jul 18, 2023
@nabim777 nabim777 changed the title [tests-only][full-ci]Add test for search restored files using context [tests-only][full-ci]Add test for search restored files using content Jul 18, 2023
@nabim777 nabim777 force-pushed the search-restored-files-using-context branch from a11b5ec to c84c0cf Compare July 19, 2023 06:15
@nabim777 nabim777 requested a review from grgprarup July 19, 2023 06:15
amrita-shrestha
amrita-shrestha reviewed Jul 19, 2023
View reviewed changes
tests/acceptance/features/apiFullTextSearch/search.feature Outdated
Given using <dav-path-version> DAV path
And user "Alice" has created folder "uploadFolder"
And user "Alice" has uploaded file with content "hello world from nepal" to "keywordAtStart.txt"
And user "Alice" has uploaded file with content "saying hello to the world" to "uploadFolder/keywordAtMiddle.txt"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any specific reason to upload file inside folder otherwise we could add this step in background

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, these two steps can go to background
Given using <dav-path-version> DAV path
And user "Alice" has uploaded file with content "hello world from nepal" to "keywordAtStart.txt"

Copy link
Member Author

@nabim777 nabim777 Jul 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is not able to put a step containing an example table in the background Given using <dav-path-version> DAV path
But
I think it is good to make another PR since there are many changes to be done in many scenarios while putting the background to files and folder steps

I think following can be added since there will check for files inside/outside the folder/subfolder

background: 

And user "Alice" has created the following folders
      | path                      |
      | folderWithFile            |
      | folderWithFile/subFolder/ |

 And user "Alice" has uploaded the following files with content "some data"
      | path                                             |
      | test.txt                                         |
      | folderWithFile/fileInsideFolder.txt              |
      | folderWithFile/subFolder/fileInsideSubFolder.txt |

tests/acceptance/features/apiFullTextSearch/search.feature Outdated Show resolved Hide resolved
SagarGi
SagarGi reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other LGTM 👍

@nabim777 nabim777 force-pushed the search-restored-files-using-context branch 4 times, most recently from 129be86 to 5a68c2a Compare July 21, 2023 11:13
saw-jan
saw-jan reviewed Jul 24, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabim777 nabim777 force-pushed the search-restored-files-using-context branch from 5a68c2a to 46c2fa8 Compare July 24, 2023 06:18
@nabim777 nabim777 force-pushed the search-restored-files-using-context branch from 46c2fa8 to 4f43cef Compare July 24, 2023 10:06
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit de550b7 into master Jul 25, 2023
ownclouders pushed a commit that referenced this pull request Jul 25, 2023
@nabim777
add api test for search restored file through tag (#6709)
2fa48e4
@nabim777 nabim777 mentioned this pull request Jul 26, 2023
Merged
@nabim777 nabim777 deleted the search-restored-files-using-context branch August 12, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@grgprarup grgprarup Awaiting requested review from grgprarup

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@SagarGi SagarGi Awaiting requested review from SagarGi

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nabim777 @grgprarup @SagarGi @saw-jan @amrita-shrestha