Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Add test for search deleted files using content #6707

Merged
merged 1 commit into from
Jul 20, 2023
Merged

[tests-only][full-ci]Add test for search deleted files using content #6707

merged 1 commit into from
Jul 20, 2023

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Jul 4, 2023 •
edited
Loading

Description

This PR adds the API tests for search deleted files using content. The scenarios added in this PR are

Related Issue

Motivation and Context

  • there was no test coverage for api test for search deleted files using content. so, this PR covers the require scenario test case

How Has This Been Tested?

  • test environment:
  • locally
  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 self-assigned this Jul 4, 2023
@nabim777 nabim777 mentioned this pull request Jul 4, 2023
Closed
51 tasks
@nabim777 nabim777 force-pushed the search-deleted-using-context branch 4 times, most recently from 73693e2 to 2e0c574 Compare July 18, 2023 04:50
@nabim777 nabim777 marked this pull request as ready for review July 18, 2023 04:52
@saw-jan saw-jan changed the title [tests-only][full-ci]Search deleted using context [tests-only][full-ci]Search deleted using content Jul 18, 2023
@nabim777 nabim777 changed the title [tests-only][full-ci]Search deleted using content [tests-only][full-ci]Add test for search deleted files using content Jul 18, 2023
@nabim777 nabim777 force-pushed the search-deleted-using-context branch 2 times, most recently from 07a8b21 to 101a02c Compare July 19, 2023 05:58
@nabim777 nabim777 requested review from grgprarup and saw-jan July 19, 2023 06:16
@nabim777 nabim777 force-pushed the search-deleted-using-context branch from 101a02c to 40d076b Compare July 19, 2023 07:34
saw-jan
saw-jan reviewed Jul 19, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SagarGi
SagarGi reviewed Jul 20, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@nabim777 nabim777 force-pushed the search-deleted-using-context branch from 40d076b to c71358d Compare July 20, 2023 06:23
SwikritiT
SwikritiT reviewed Jul 20, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@saw-jan saw-jan merged commit 531efe0 into master Jul 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the search-deleted-using-context branch July 20, 2023 07:13
ownclouders pushed a commit that referenced this pull request Jul 20, 2023
@nabim777
add test for search deleted file using context (#6707)
8ae7c81
@nabim777 nabim777 mentioned this pull request Jul 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@SagarGi SagarGi SagarGi left review comments

@SwikritiT SwikritiT SwikritiT approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@grgprarup grgprarup Awaiting requested review from grgprarup

Assignees

@nabim777 nabim777

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nabim777 @grgprarup @SwikritiT @SagarGi @saw-jan