-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci][tests-only] Check id file owner in response #6627
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,22 +1,22 @@ | ||||||
@api | ||||||
@api | ||||||
Feature: Share a file or folder that is inside a space via public link | ||||||
As a user with manager space role | ||||||
I want to be able to share the data inside the space via public link | ||||||
So that an anonymous user can have access to certain resources | ||||||
As a user with manager space role | ||||||
I want to be able to share the data inside the space via public link | ||||||
So that an anonymous user can have access to certain resources | ||||||
|
||||||
folder permissions: | ||||||
| role | permissions | | ||||||
| internal | 0 | | ||||||
| viewer | 1 | | ||||||
| uploader | 4 | | ||||||
| contributor | 5 | | ||||||
| editor | 15 | | ||||||
folder permissions: | ||||||
| role | permissions | | ||||||
| internal | 0 | | ||||||
| viewer | 1 | | ||||||
| uploader | 4 | | ||||||
| contributor | 5 | | ||||||
| editor | 15 | | ||||||
|
||||||
file permissions: | ||||||
| role | permissions | | ||||||
| internal | 0 | | ||||||
| viewer | 1 | | ||||||
| editor | 3 | | ||||||
file permissions: | ||||||
| role | permissions | | ||||||
| internal | 0 | | ||||||
| viewer | 1 | | ||||||
| editor | 3 | | ||||||
|
||||||
Note - this feature is run in CI with ACCOUNTS_HASH_DIFFICULTY set to the default for production | ||||||
See https://github.com/owncloud/ocis/issues/1542 and https://github.com/owncloud/ocis/pull/839 | ||||||
|
@@ -44,7 +44,7 @@ Feature: Share a file or folder that is inside a space via public link | |||||
Then the HTTP status code should be "200" | ||||||
And the OCS status code should be "200" | ||||||
And the OCS status message should be "OK" | ||||||
And the fields of the last response to user "Alice" should include | ||||||
And the fields of the last response to user "Alice" and space "share sub-item" should include | ||||||
| item_type | <item_type> | | ||||||
| mimetype | <mimetype> | | ||||||
| file_target | <file_target> | | ||||||
|
@@ -53,6 +53,8 @@ Feature: Share a file or folder that is inside a space via public link | |||||
| share_type | public_link | | ||||||
| displayname_owner | %displayname% | | ||||||
| name | <name> | | ||||||
| uid_file_owner | %space_id% | | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
is file owner id same as space id ? As far as i remember it is different than that of a space id. If different then we can name it something like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would be say that is different format.
|
||||||
| space_id | %space_id% | | ||||||
Examples: | ||||||
| entity | file_target | permissions | password | name | expireDate | item_type | mimetype | | ||||||
| folder | /folder | 0 | | link | | folder | httpd/unix-directory | | ||||||
|
@@ -79,14 +81,16 @@ Feature: Share a file or folder that is inside a space via public link | |||||
Then the HTTP status code should be "200" | ||||||
And the OCS status code should be "200" | ||||||
And the OCS status message should be "OK" | ||||||
And the fields of the last response to user "Brian" should include | ||||||
And the fields of the last response to user "Brian" and space "share sub-item" should include | ||||||
| item_type | <item_type> | | ||||||
| mimetype | <mimetype> | | ||||||
| file_target | <file_target> | | ||||||
| path | /<entity> | | ||||||
| share_type | public_link | | ||||||
| displayname_owner | %displayname% | | ||||||
| name | public link | | ||||||
| uid_file_owner | %space_id% | | ||||||
| space_id | %space_id% | | ||||||
Examples: | ||||||
| entity | file_target | item_type | mimetype | | ||||||
| folder | /folder | folder | httpd/unix-directory | | ||||||
|
@@ -115,7 +119,7 @@ Feature: Share a file or folder that is inside a space via public link | |||||
| folder/file.txt | viewer | | ||||||
|
||||||
|
||||||
Scenario Outline: user creates a new public link share of a file with edit permissions | ||||||
Scenario Outline: user creates a new public link share of a file inside the personal space with edit permissions | ||||||
Given using OCS API version "<ocs_api_version>" | ||||||
And user "Alice" has uploaded file with content "Random data" to "/file.txt" | ||||||
When user "Alice" creates a public link share using the sharing API with settings | ||||||
|
@@ -150,7 +154,7 @@ Feature: Share a file or folder that is inside a space via public link | |||||
| path | folder/file.txt | | ||||||
| shareType | 3 | | ||||||
| permissions | 1 | | ||||||
Then the fields of the last response to user "Alice" should include | ||||||
Then the fields of the last response to user "Alice" and space "share sub-item" should include | ||||||
| item_type | file | | ||||||
| mimetype | text/plain | | ||||||
| file_target | /file.txt | | ||||||
|
@@ -159,8 +163,9 @@ Feature: Share a file or folder that is inside a space via public link | |||||
| share_type | public_link | | ||||||
| displayname_file_owner | | | ||||||
| displayname_owner | %displayname% | | ||||||
#| uid_file_owner | %username% | | ||||||
| uid_owner | %username% | | ||||||
| uid_file_owner | %space_id% | | ||||||
| space_id | %space_id% | | ||||||
And for user "Brian" the space "share sub-item" should contain the last created public link of the file "folder/file.txt" | ||||||
Examples: | ||||||
| spaceRole | | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍