Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci][tests-only] Check id file owner in response #6627

Merged
merged 2 commits into from
Jun 27, 2023
Merged

[full-ci][tests-only] Check id file owner in response #6627

merged 2 commits into from
Jun 27, 2023

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Jun 26, 2023 •
edited
Loading

related #6606

after fixing b108482 I changed tests

  • added checking spaceID in response
  • uid_file_owner = spaceId for project space

@ScharfViktor ScharfViktor force-pushed the check_id_file_owner_in_Response branch 2 times, most recently from 36f230c to b82444c Compare June 26, 2023 15:51
@ScharfViktor ScharfViktor marked this pull request as ready for review June 26, 2023 15:51
@ScharfViktor ScharfViktor mentioned this pull request Jun 26, 2023
Closed
51 tasks
@ownclouders
Copy link
Contributor

ownclouders commented Jun 26, 2023 •
edited
Loading

💥 Acceptance test Core-API-Tests-ocis-storage-5 failed. Further test are cancelled...

@ScharfViktor ScharfViktor changed the title Check id file owner in response [full-ci]Check id file owner in response Jun 26, 2023
@ScharfViktor ScharfViktor force-pushed the check_id_file_owner_in_Response branch from 6201a7d to e55871d Compare June 26, 2023 21:26
SagarGi
SagarGi reviewed Jun 27, 2023
View reviewed changes
tests/acceptance/features/bootstrap/Sharing.php Outdated Show resolved Hide resolved
tests/acceptance/features/apiSpacesShares/shareSubItemOfSpaceViaPublicLink.feature
@@ -53,6 +53,8 @@ Feature: Share a file or folder that is inside a space via public link
| share_type | public_link |
| displayname_owner | %displayname% |
| name | <name> |
| uid_file_owner | %space_id% |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| uid_file_owner | %space_id% |
| uid_file_owner | %space_id% |

is file owner id same as space id ? As far as i remember it is different than that of a space id. If different then we can name it something like %file_owner_id%.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be say that is different format.

getSpaceIdByName - gives me 01e1375f-9f56-4e71-bb9f-2e750db67385$6cf15f71-7900-4f97-9e3a-69a467f56c41
uid_file_owner - gives me spaceId but shortly 6cf15f71-7900-4f97-9e3a-69a467f56c41
space_id - gives me spaceId in format <storageid>$<spaceid>!<opaqueid> - 01e1375f-9f56-4e71-bb9f-2e750db67385$6cf15f71-7900-4f97-9e3a-69a467f56c41!6cf15f71-7900-4f97-9e3a-69a467f56c41

@phil-davis phil-davis changed the title [full-ci]Check id file owner in response [full-ci][tests-only] Check id file owner in response Jun 27, 2023
@ScharfViktor ScharfViktor requested a review from SagarGi June 27, 2023 07:45
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ScharfViktor ScharfViktor added the Status:Needs-Review Needs review from a maintainer label Jun 27, 2023
saw-jan
saw-jan reviewed Jun 27, 2023
View reviewed changes
tests/acceptance/config/behat.yml
Comment on lines -26 to -33
- ChecksumContext:
- FavoritesContext:
- FilesVersionsContext:
- NotificationContext:
- OCSContext:
- PublicWebDavContext:
- TrashbinContext:
- WebDavPropertiesContext:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

saw-jan
saw-jan approved these changes Jun 27, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ScharfViktor ScharfViktor merged commit 753c8f2 into master Jun 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the check_id_file_owner_in_Response branch June 27, 2023 10:50
ownclouders pushed a commit that referenced this pull request Jun 27, 2023
@ScharfViktor
[full-ci][tests-only] Check id file owner in response (#6627)
318d990 
* check owner as spaceId in sharing response

* fix after review
@saw-jan saw-jan mentioned this pull request Jun 30, 2023
Closed
fschade pushed a commit that referenced this pull request Jul 10, 2023
@ScharfViktor @fschade
[full-ci][tests-only] Check id file owner in response (#6627)
2b01a7e 
* check owner as spaceId in sharing response

* fix after review
@grgprarup grgprarup mentioned this pull request Jul 24, 2023
Merged
@SwikritiT SwikritiT mentioned this pull request Jul 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@SagarGi SagarGi Awaiting requested review from SagarGi

Assignees
No one assigned
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ScharfViktor @ownclouders @SagarGi @saw-jan