[tests-only] [full-ci] Refactoring unshare step definition code #6608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💥 Acceptance test Core-API-Tests-ocis-storage-2 failed. Further test are cancelled... |
S-Panta
changed the title
SwikritiT
requested review from
grgprarup,
SagarGi,
saw-jan,
amrita-shrestha and
PrajwolAmatya
S-Panta
requested review from
amrita-shrestha,
PrajwolAmatya,
SwikritiT and
grgprarup
and removed request for
grgprarup,
SagarGi,
amrita-shrestha and
PrajwolAmatya
SagarGi
reviewed
Jun 26, 2023
...eatures/coreApiShareCreateSpecialToShares2/createShareDefaultFolderForReceivedShares.feature
Outdated
Show resolved
Hide resolved
tests/acceptance/features/coreApiShareManagementBasicToShares/deleteShareFromShares.feature
Outdated
Show resolved
Hide resolved
SwikritiT
reviewed
Jun 26, 2023
...eatures/coreApiShareCreateSpecialToShares2/createShareDefaultFolderForReceivedShares.feature
Outdated
Show resolved
Hide resolved
9 tasks
saw-jan
reviewed
Jun 27, 2023
saw-jan
reviewed
Jun 27, 2023
...eatures/coreApiShareCreateSpecialToShares2/createShareDefaultFolderForReceivedShares.feature
Outdated
Show resolved
Hide resolved
saw-jan
reviewed
Jun 28, 2023
| @@ -421,7 +421,7 @@ Feature: dav-versions | |||
| | new | Brian | /testshare | | |||
|
|
|||
|
|
|||
| Scenario: receiver tries to get file versions of unshared file from the sharer | |||
| Scenario: sharee tries to get file versions of file not shared by the sharer | |||
There was a problem hiding this comment.
IMO, should be fine there. This scenario tests the edge case that when textfile0 is shared with Brian, he cannot view the versions of another unshared file of Alice.
|
Kudos, SonarCloud Quality Gate passed!
|
saw-jan
approved these changes
Jun 30, 2023
ownclouders
pushed a commit
that referenced
this pull request
Jun 30, 2023
* added unshare scenerio * remove unshare keyword from step definition * refactoring of step definition codes * refactor
S-Panta
added a commit
that referenced
this pull request
Jun 30, 2023
*added unshare scenerio * remove unshare keyword from step definition * refactoring of step definition codes * refactor
saw-jan
pushed a commit
that referenced
this pull request
Jul 3, 2023
… (#6679) *added unshare scenerio * remove unshare keyword from step definition * refactoring of step definition codes * refactor
ownclouders
pushed a commit
that referenced
this pull request
Jul 3, 2023
… (#6679) *added unshare scenerio * remove unshare keyword from step definition * refactoring of step definition codes * refactor
fschade
pushed a commit
that referenced
this pull request
Jul 10, 2023
* added unshare scenerio * remove unshare keyword from step definition * refactoring of step definition codes * refactor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the step definition code relating to unshare scenerio.
Related Issue
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: