[tests-only][full-ci] Refactor share related scenerio #6587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
S-Panta
commented
Jun 23, 2023
| @@ -3338,7 +3338,7 @@ public function fileHasBeenDeleted(string $file, string $user):void { | |||
| } | |||
|
|
|||
| /** | |||
| * @When /^user "([^"]*)" (?:deletes|unshares) (?:file|folder) "([^"]*)" using the WebDAV API$/ | |||
| * @When /^user "([^"]*)" deletes (?:file|folder) "([^"]*)" using the WebDAV API$/ | |||
There was a problem hiding this comment.
Suggested change
| * @When /^user "([^"]*)" deletes (?:file|folder) "([^"]*)" using the WebDAV API$/ | |
| * @When user :user deletes file/folder :file using the WebDAV API |
|
The CI is failing because of --- FeatureContext has missing steps. Define them with these snippets:
/**
* @When user :arg1 unshares folder :arg2 using the WebDAV API
*/
public function userUnsharesFolderUsingTheWebdavApi($arg1, $arg2)
{
throw new PendingException();
}
Undefined steps: There were some undefined steps found.
make: *** [Makefile:125: test-acceptance-from-core-api] Error 1
make: Leaving directory '/drone/src' |
|
Since this issue is further explored here #6608 , this PR shall be closed to avoid the confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously when the sharer unshares the file to sharee, sharer actually deletes the resources rather than removing sharee from the shares. There is no actual scenario that tests for the unshare feature.
This PR adds a new missing test scenario and refactors the shares related step definition codes
Related Issue
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: