Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error status when the user share the locked file #6358

Merged
merged 1 commit into from
May 23, 2023
Merged

Fix error status when the user share the locked file #6358

merged 1 commit into from
May 23, 2023

Conversation

2403905
Copy link
Contributor

@2403905 2403905 commented May 22, 2023 •
edited
Loading

Description

Fix the response error code and unexpected behavior when the user tries to share the locked file

Related Issue

How Has This Been Tested?

  • test environment: local
  • test case 1:
  • Login as admin
  • Create a new Microsoft Word file in the "Personal" new.docx
  • Open new.docx for editing
  • Try to share the new.docx with another user
  • See the expected error message that file is locked

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@2403905 2403905 force-pushed the issue-6197 branch 2 times, most recently from 829f029 to aff4d53 Compare May 22, 2023 09:35
@ownclouders
Copy link
Contributor

💥 Acceptance test localApiTests-apiAsyncUpload-ocis failed. Further test are cancelled...

@2403905 2403905 marked this pull request as ready for review May 22, 2023 13:30
@2403905 2403905 requested review from micbar and kobergj and removed request for micbar May 22, 2023 13:31
@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@2403905 2403905 merged commit 069e751 into owncloud:master May 23, 2023
ownclouders pushed a commit that referenced this pull request May 23, 2023
@2403905
Merge pull request #6358 from 2403905/issue-6197
8a4a33c 
Fix error status when the user share the locked file
@ScharfViktor ScharfViktor mentioned this pull request Oct 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@micbar micbar Awaiting requested review from micbar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ocis vs ldap. Cannot share a file that is open in collabora
3 participants
@2403905 @ownclouders @kobergj