Ocis vs ldap. Cannot share a file that is open in collabora

[ScharfViktor]

ocis 3.0.0-rc.1
web 7.0.0-rc.32

ocis against wopi using https://github.com/owncloud/ocis/blob/master/deployments/examples/ocis_wopi/docker-compose.yml
or open ocis.ocis-wopi.released.owncloud.works

Steps:

• share opening in the onlyOffice file to user

Actual: 996 grpc create share request failed

Screen.Recording.2023-05-01.at.22.47.32.mov

Expected:

[micbar]

The file is locked, that is the reason why this doesn't work.

@tbsbdr @kulmann This demands better error handling.

[tbsbdr]

assessing as p2 as it can block collaboration with no workaround (example: this bug can stop a teaching lesson for certain pupils)

[micbar]

Error handling will not enable sharing a locked resource.

1. We should get a better error message to the user.
2. We cannot share the file until the last person has left the editing session.

[2403905]

Error handling will not enable sharing a locked resource.

1. We should get a better error message to the user.
2. We cannot share the file until the last person has left the editing session.

@micbar What error users have to see?

[2403905]

@ScharfViktor Looks like we have multiple bugs.

1. Steps from the video
   1.1 The document still opened via only office
   1.2 If Sharer try share one more time the response will be

<ocs><meta><status>error</status><statuscode>400</statuscode><message>grantee already has a share on this item</message></meta></ocs>

1.3 Goto files/shares/with-others -> the share is already created!

2. log in as Sharee.
   2.1 Sharee can see Notifications!
   2.2 goto shares -> files/shares/with-me is empty

[2403905]

@micbar @tbsbdr How to handle the case below?
Case 2

1. Bob create a doc
   2 Bob edit and close a doc
   3 Bob share a doc to Oggy
   4 Oggy open a doc
   5 Bob going to share the doc with Jack -> lock ! Oggy left the doc opened for a long time!

[micbar]

5 Bob going to share the doc with Jack -> lock ! Oggy left the doc opened for a long time!

Bob should get a message that the document is locked with the call to action to try it later.

IMO that is the best we could do ATM

[tbsbdr]

Proposal for error notification:

Sorry, sharing is not possible

The document is being edited and is locked. Please finish editing to enable sharing.

[2403905]

@tbsbdr Is the frontend should provide this message?
I can return create share <?xml version="1.0" encoding="UTF-8"?> <ocs><meta><status>error</status><statuscode>423</statuscode><message>add grant: error: locked by opaquelocktoken:797356a8-0500-4ceb-a8a0-c94c8cde7eba RCtDdTFGUmE5K3JnRU1mdDhYSUpHQT09</message></meta></ocs>
or more common message and then the client has to determine what exactly is locked.

[ScharfViktor]

retested v. 3.0.0-rc.4

• share opening in the onlyOffice file to user - fixed. The file is locked until the file is in use by at least one user
• edit share opening in the onlyOffice file to user - 996 error
• delete share opening in the onlyOffice file to user - 996 error