Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci][tests-only]Extend notification api tests #6324

Merged
merged 2 commits into from
May 24, 2023
Merged

[full-ci][tests-only]Extend notification api tests #6324

merged 2 commits into from
May 24, 2023

Conversation

amrita-shrestha
Copy link
Contributor

Description

This PR adds tests for notification

  • Scenario Outline: user gets a notification of resource sharing
  • Scenario Outline: user gets a notification of unsharing resource

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha force-pushed the extend-notification-api-tests branch from fe652a0 to 46e0950 Compare May 16, 2023 11:05
@amrita-shrestha amrita-shrestha mentioned this pull request May 16, 2023
Closed
@amrita-shrestha amrita-shrestha force-pushed the extend-notification-api-tests branch 2 times, most recently from f003836 to f73141f Compare May 18, 2023 03:58
@amrita-shrestha amrita-shrestha marked this pull request as ready for review May 18, 2023 04:18
@amrita-shrestha amrita-shrestha self-assigned this May 18, 2023
@amrita-shrestha amrita-shrestha force-pushed the extend-notification-api-tests branch from 9f35102 to e7f614a Compare May 22, 2023 04:30
@amrita-shrestha amrita-shrestha requested a review from saw-jan May 22, 2023 04:33
@amrita-shrestha amrita-shrestha force-pushed the extend-notification-api-tests branch from e7f614a to 5d4cc71 Compare May 22, 2023 04:44
@amrita-shrestha amrita-shrestha force-pushed the extend-notification-api-tests branch from 5d4cc71 to 437a7a8 Compare May 23, 2023 03:55
@amrita-shrestha amrita-shrestha requested a review from saw-jan May 23, 2023 03:56
@amrita-shrestha amrita-shrestha force-pushed the extend-notification-api-tests branch from 437a7a8 to 93df6ed Compare May 23, 2023 06:18
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

saw-jan
saw-jan reviewed May 23, 2023
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ScharfViktor
Copy link
Contributor

I like that all notifications in the ApiNotification suit.

could you please move tests (delete same tests) from #6254 to suit ApiNotification ?

@amrita-shrestha
Copy link
Contributor Author

amrita-shrestha commented May 24, 2023 •
edited
Loading

I like that all notifications in the ApiNotification suit.

could you please move tests (delete same tests) from #6254 to suit ApiNotification ?

@ScharfViktor there is an upcoming PR that moves tests #6372

@saw-jan saw-jan merged commit 53ee61a into master May 24, 2023
@delete-merged-branch delete-merged-branch bot deleted the extend-notification-api-tests branch May 24, 2023 07:11
ownclouders pushed a commit that referenced this pull request May 24, 2023
@amrita-shrestha
[full-ci][tests-only]Extend notification api tests (#6324)
42076d5 
* Add api tests for notification

* Address review
fschade pushed a commit that referenced this pull request Jul 10, 2023
@amrita-shrestha @fschade
[full-ci][tests-only]Extend notification api tests (#6324)
2ba6afa 
* Add api tests for notification

* Address review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan left review comments

@SagarGi SagarGi SagarGi left review comments

@SwikritiT SwikritiT SwikritiT left review comments

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@amrita-shrestha amrita-shrestha

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amrita-shrestha @ScharfViktor @SwikritiT @SagarGi @saw-jan