[test-only][full-ci] Api tests. get notification on different languages #6254
Conversation
ScharfViktor
commented
May 8, 2023
ScharfViktor
commented
- set and get languages setting
- get notification on different languages
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
ScharfViktor
force-pushed
the
languageSwitchTest
branch
from
05f4454 to
2febdb9
Compare
|
💥 Acceptance test wopiValidatorTests-ocis failed. Further test are cancelled... |
no, accidentally commited |
ScharfViktor
force-pushed
the
languageSwitchTest
branch
from
765efc9 to
9d0d501
Compare
| "properties": { | ||
| "id": { | ||
| "type": "string", | ||
| "pattern": "^[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}\\$[a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}![a-fA-F0-9]{8}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{4}-[a-fA-F0-9]{12}$" |
There was a problem hiding this comment.
may be we can make a function and name what type of regex pattern is ths and substitute. may be we can use such pattern in other place as well.
There was a problem hiding this comment.
It's space id like 3db75261-afa8-4224-9c10-f8459fd047d7$1eb6a3e9-5dba-4887-b1b2-0c26d73d4e83!1eb6a3e9-5dba-4887-b1b2-0c26d73d4e83
We have pattern for checking spaceID but my spaceUUID contains ! . self::getUUIDv4Regex() -> maybe it is bug(because objectId is normal spaceId).
public static function getSpaceIdRegex(): string {
return self::getUUIDv4Regex() . '\\\$' . self::getUUIDv4Regex();
Otherwise I have to add something like:
public static function getFullSpaceIdRegex(): string {
return self::getUUIDv4Regex() . '\\\$' . self::getUUIDv4Regex(). '\\\!' . self::getUUIDv4Regex();
ScharfViktor
force-pushed
the
languageSwitchTest
branch
from
d45072a to
ca9e6c3
Compare
amrita-shrestha
changed the title
…es (#6254) * get notification on different languages * set default english if no configured * fix * fix after review * fix after rebase * after review
…es (#6254) * get notification on different languages * set default english if no configured * fix * fix after review * fix after rebase * after review
