Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only]Refactor feature files to add correct description #6162

Merged
merged 3 commits into from
May 4, 2023
Merged

[tests-only]Refactor feature files to add correct description #6162

merged 3 commits into from
May 4, 2023

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Apr 27, 2023 •
edited
Loading

Description

This PR

  • adds the description about the feature file
  • updates the line changes in expected to fail file
  • start the scenario title with small letter and without article
  • remove the duplication of scenario title within a feature file

Related Issue

Motivation and Context

This is to maintain uniformity within the scenarios in a feature file

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@ownclouders
Copy link
Contributor

ownclouders commented Apr 27, 2023 •
edited
Loading

💥 Acceptance test Core-API-Tests-ocis-storage-6 failed. Further test are cancelled...

@SwikritiT SwikritiT changed the title Refactor feature files to add correct description [tests-only][full-ci]Refactor feature files to add correct description Apr 27, 2023
@SwikritiT SwikritiT force-pushed the enh/refactor-feature-file branch from f5cc724 to d113c5a Compare April 27, 2023 10:14
@SwikritiT SwikritiT self-assigned this Apr 27, 2023
@owncloud owncloud deleted a comment from update-docs bot Apr 27, 2023
@SwikritiT SwikritiT force-pushed the enh/refactor-feature-file branch from 06fd058 to 1d88139 Compare May 2, 2023 05:03
@SwikritiT SwikritiT marked this pull request as ready for review May 2, 2023 05:03
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT SwikritiT requested a review from ScharfViktor May 2, 2023 08:57
grgprarup
grgprarup reviewed May 2, 2023
View reviewed changes
Copy link
Contributor

@grgprarup grgprarup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SwikritiT SwikritiT changed the title [tests-only][full-ci]Refactor feature files to add correct description [tests-only] Refactor feature files to add correct description May 3, 2023
@SwikritiT SwikritiT changed the title [tests-only] Refactor feature files to add correct description [tests-only]Refactor feature files to add correct description May 3, 2023
@SwikritiT SwikritiT force-pushed the enh/refactor-feature-file branch from 1d88139 to 7a195ea Compare May 3, 2023 04:51
@phil-davis phil-davis merged commit 6400151 into master May 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the enh/refactor-feature-file branch May 4, 2023 03:43
ownclouders pushed a commit that referenced this pull request May 4, 2023
@phil-davis
Merge pull request #6162 from owncloud/enh/refactor-feature-file
6762741 
[tests-only]Refactor feature files to add correct description
@SwikritiT SwikritiT mentioned this pull request May 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grgprarup grgprarup grgprarup left review comments

@phil-davis phil-davis phil-davis approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@saw-jan saw-jan Awaiting requested review from saw-jan

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SwikritiT @ownclouders @phil-davis @grgprarup