Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor feature file according to rule #804

Closed
1 task
amrita-shrestha opened this issue Mar 23, 2023 · 2 comments
Closed
1 task

Refactor feature file according to rule #804

amrita-shrestha opened this issue Mar 23, 2023 · 2 comments
Assignees
Labels

Comments

@amrita-shrestha
Copy link

amrita-shrestha commented Mar 23, 2023

Description

Currently, we have feature files that don't follow rules as described in https://doc.owncloud.com/server/10.11/developer_manual/testing/acceptance-tests.html#how-to-write-acceptance-tests

Example:

Using simple comments

  Only user with admin and SpaceAdmin permissions can create new spaces

rather than

  As a [role]
  I want [feature]
  So that [benefit]

Following the same pattern in the whole scenario
Example

 Scenario Outline: An admin or space admin user can create a Space via the Graph API with a default quota ❌ 

 Scenario Outline: admin or space admin user can create a Space via the Graph API with a default quota ✅ 

TODO

  • ocis
    - [ ] web might not bee needed as we don't maintain the Nightwatch code and the e2e doesn't follow this pattern at all

Points to remember while refactoring

  1. don't start the scenario title with an uppercase letter
  2. don't start the scenario title with an article
  3. don't duplicate a scenario title within a feature file (if duplicate scenario titles are present differentiate them according to their actions)
  4. add a proper description to a feature
@SwikritiT
Copy link

SwikritiT commented May 26, 2023

The suites that needs to be refactored:

@PrajwolAmatya
Copy link

Feature files on these suites has been refactored according to the rules. So, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants