-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci] api test to set quota by users with different roles #5854
Conversation
cff5162
to
183bae8
Compare
bec722d
to
aa25f3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
other LGTM 👍
aa25f3f
to
f90c57d
Compare
f90c57d
to
7e46e2e
Compare
7d4b375
to
09ae600
Compare
09ae600
to
ca46b24
Compare
@PrajwolAmatya please check if there is a scenario that covers setting quota multiple times. And any API to get quota information. |
ca46b24
to
f7a8fab
Compare
I couldn't find specific API to get quota information but quota information can be received while getting information of the spaces. |
d769cc8
to
40ccb94
Compare
14f1433
to
d7db566
Compare
d7db566
to
5cab9bb
Compare
5cab9bb
to
bc8a839
Compare
E2E tests failed: https://drone.owncloud.com/owncloud/ocis/20783/86/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/20783/tracing/admin-deletes-group-admin-2023-3-24-05-37-31.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/20783/tracing/unstructured-collection-of-testable-space-interactions-alice-2023-3-24-05-48-03.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/20783/tracing/user-group-assignments-can-be-handled-via-batch-actions-admin-2023-3-24-05-38-21.zip |
bc8a839
to
efb4ce3
Compare
efb4ce3
to
05ac9a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This branch is [1 commit ahead](https://github.com/owncloud/ocis/compare/master...test-for-set-quota-for-differnt-users), [79 commits behind](https://github.com/owncloud/ocis/compare/test-for-set-quota-for-differnt-users...master) master.
Can you rebase first?
05ac9a3
to
ff23465
Compare
ff23465
to
5294ce5
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if CI passes
Description
This PR adds API test to set quota by users with different roles
Related Issue
Related to issue: #5565
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: