Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] api test to set quota by users with different roles #5854

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

PrajwolAmatya
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya commented Mar 16, 2023

Description

This PR adds API test to set quota by users with different roles

Related Issue

Related to issue: #5565

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PrajwolAmatya PrajwolAmatya self-assigned this Mar 16, 2023
@PrajwolAmatya PrajwolAmatya force-pushed the test-for-set-quota-for-differnt-users branch from cff5162 to 183bae8 Compare March 16, 2023 10:06
@PrajwolAmatya PrajwolAmatya force-pushed the test-for-set-quota-for-differnt-users branch 2 times, most recently from bec722d to aa25f3f Compare March 16, 2023 11:25
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other LGTM 👍

@PrajwolAmatya PrajwolAmatya force-pushed the test-for-set-quota-for-differnt-users branch from aa25f3f to f90c57d Compare March 17, 2023 03:53
@PrajwolAmatya PrajwolAmatya force-pushed the test-for-set-quota-for-differnt-users branch from f90c57d to 7e46e2e Compare March 17, 2023 06:09
@PrajwolAmatya PrajwolAmatya requested a review from saw-jan March 17, 2023 06:42
@PrajwolAmatya PrajwolAmatya force-pushed the test-for-set-quota-for-differnt-users branch 2 times, most recently from 7d4b375 to 09ae600 Compare March 17, 2023 08:29
@PrajwolAmatya PrajwolAmatya force-pushed the test-for-set-quota-for-differnt-users branch from 09ae600 to ca46b24 Compare March 17, 2023 10:12
@amrita-shrestha
Copy link
Contributor

@PrajwolAmatya please check if there is a scenario that covers setting quota multiple times. And any API to get quota information.

@PrajwolAmatya PrajwolAmatya force-pushed the test-for-set-quota-for-differnt-users branch from ca46b24 to f7a8fab Compare March 20, 2023 06:06
@PrajwolAmatya
Copy link
Contributor Author

@PrajwolAmatya please check if there is a scenario that covers setting quota multiple times. And any API to get quota information.

I couldn't find specific API to get quota information but quota information can be received while getting information of the spaces.

@PrajwolAmatya PrajwolAmatya force-pushed the test-for-set-quota-for-differnt-users branch from d769cc8 to 40ccb94 Compare March 22, 2023 03:57
@PrajwolAmatya PrajwolAmatya force-pushed the test-for-set-quota-for-differnt-users branch 2 times, most recently from 14f1433 to d7db566 Compare March 22, 2023 05:23
@PrajwolAmatya PrajwolAmatya force-pushed the test-for-set-quota-for-differnt-users branch from d7db566 to 5cab9bb Compare March 23, 2023 09:46
@PrajwolAmatya PrajwolAmatya requested a review from grgprarup March 24, 2023 04:12
@PrajwolAmatya PrajwolAmatya force-pushed the test-for-set-quota-for-differnt-users branch from 5cab9bb to bc8a839 Compare March 24, 2023 04:52
@PrajwolAmatya PrajwolAmatya requested a review from SwikritiT March 24, 2023 04:54
@PrajwolAmatya PrajwolAmatya force-pushed the test-for-set-quota-for-differnt-users branch from bc8a839 to efb4ce3 Compare March 24, 2023 05:29
@PrajwolAmatya PrajwolAmatya force-pushed the test-for-set-quota-for-differnt-users branch from efb4ce3 to 05ac9a3 Compare March 24, 2023 06:42
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch is [1 commit ahead](https://github.com/owncloud/ocis/compare/master...test-for-set-quota-for-differnt-users), [79 commits behind](https://github.com/owncloud/ocis/compare/test-for-set-quota-for-differnt-users...master) master.

Can you rebase first?

@PrajwolAmatya PrajwolAmatya force-pushed the test-for-set-quota-for-differnt-users branch from 05ac9a3 to ff23465 Compare March 24, 2023 11:34
@PrajwolAmatya PrajwolAmatya requested a review from SwikritiT March 24, 2023 11:35
@PrajwolAmatya PrajwolAmatya force-pushed the test-for-set-quota-for-differnt-users branch from ff23465 to 5294ce5 Compare March 27, 2023 03:45
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes

@PrajwolAmatya PrajwolAmatya merged commit 27fa742 into master Mar 27, 2023
@delete-merged-branch delete-merged-branch bot deleted the test-for-set-quota-for-differnt-users branch March 27, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants