Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-only] Change Testing section in the doc #5430

Merged
merged 2 commits into from
Jan 20, 2023

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Jan 19, 2023

when @Excds tried to run api test based on the documentation, it turned out that the docs is not up to date
I updated docs tests agains ocis binary

@phil-davis @individual-it could you please have look on the https://owncloud.dev/ocis/development/testing/#testing-with-test-suite-in-docker part. it practically doesn't work. does it need to be fixed?

Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the testing docs is outdated. Thank you for this PR. Just a few suggestions otherwise looks good to me. I'll look into the docker section and make the necessary changes for testing.

docs/ocis/development/testing.md Outdated Show resolved Hide resolved
docs/ocis/development/testing.md Outdated Show resolved Hide resolved
docs/ocis/development/testing.md Show resolved Hide resolved
@SwikritiT SwikritiT removed their assignment Jan 20, 2023
@mmattel
Copy link
Contributor

mmattel commented Jan 20, 2023

Note, when I was looking at section Run ocis:

This

IDM_ADMIN_PASSWORD=admin ocis/bin/ocis init --insecure true
OCIS_INSECURE=true PROXY_ENABLE_BASIC_AUTH=true ocis/bin/ocis server

should imho be changed to

IDM_ADMIN_PASSWORD=admin \
ocis/bin/ocis init --insecure true

OCIS_INSECURE=true \
PROXY_ENABLE_BASIC_AUTH=true \
ocis/bin/ocis server

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ScharfViktor ScharfViktor merged commit eb0ad41 into master Jan 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the fixTestingSectionOnDoc branch January 20, 2023 10:54
ownclouders pushed a commit that referenced this pull request Jan 20, 2023
Author: Viktor Scharf <[email protected]>
Date:   Fri Jan 20 11:54:25 2023 +0100

    [docs-only] Change Testing section in the doc (#5430)

    * change docs

    * fix after review
ScharfViktor added a commit that referenced this pull request Jan 20, 2023
mmattel added a commit that referenced this pull request Jan 20, 2023
[docs-only] Change Testing section in the doc (#5430)
ownclouders pushed a commit that referenced this pull request Jan 20, 2023
Merge: a4a6c4b d0d0517
Author: Martin <[email protected]>
Date:   Fri Jan 20 13:09:27 2023 +0100

    Merge pull request #5437 from owncloud/changeDocTestingSection

    [docs-only] Change Testing section in the doc (#5430)
ownclouders pushed a commit that referenced this pull request Jan 22, 2023
Merge: a4a6c4b d0d0517
Author: Martin <[email protected]>
Date:   Fri Jan 20 13:09:27 2023 +0100

    Merge pull request #5437 from owncloud/changeDocTestingSection

    [docs-only] Change Testing section in the doc (#5430)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants