Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Removed unused make target, bump ocis commit id #3627

Merged
merged 3 commits into from
Jan 27, 2023

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented Jan 26, 2023

This PR removes the unused make target from Makefile, same as (#3622),
added APITESTS_REPO_GIT_URL env variable to .drone.env (#3593),
bump ocis commit id to latest
Fix owncloud/ocis#5450
Part of owncloud/QA#795

@grgprarup grgprarup force-pushed the remove-unused-make-target branch from d5c50f4 to b13ef65 Compare January 26, 2023 05:58
.drone.star Show resolved Hide resolved
@grgprarup grgprarup force-pushed the remove-unused-make-target branch 2 times, most recently from 3bbf894 to d016c06 Compare January 26, 2023 08:32
@grgprarup
Copy link
Contributor Author

Added test by PR owncloud/ocis#5415 are failing for reva-master branch https://drone.owncloud.com/cs3org/reva/327/5/6, No issue with reva-edge branch https://drone.owncloud.com/cs3org/reva/315/13/6
@phil-davis

@phil-davis
Copy link
Contributor

Added test by PR owncloud/ocis#5415 are failing for reva-master branch

That is "correct". The source-code fix would only be in edge branch.

So please add to expected-failures. In this case, there will have to be a heading with no link to any issue. Just give a general description in the heading and list the failing scenarios. I have no idea if this sort of thing will be back-ported to master.

Makefile Outdated Show resolved Hide resolved
@grgprarup grgprarup force-pushed the remove-unused-make-target branch from 438f6e0 to 14a2d5b Compare January 26, 2023 11:26
@grgprarup grgprarup marked this pull request as ready for review January 26, 2023 11:33
@grgprarup grgprarup requested review from labkode, gmgigi96, glpatcern and a team as code owners January 26, 2023 11:33
phil-davis
phil-davis previously approved these changes Jan 26, 2023
@phil-davis
Copy link
Contributor

@labkode @gmgigi96 @glpatcern this makes some further changes to Makefile and .drone.env etc that we also did in edge branch last week. See links to the edge PRs in the top post.

Please review. We can't merge Makefile changes ourselves.

@glpatcern
Copy link
Member

Looping in @vascoguita as he's fixing the CI and the build infra. The Changelog check should be skipped a priori.

vascoguita
vascoguita previously approved these changes Jan 26, 2023
glpatcern
glpatcern previously approved these changes Jan 26, 2023
@glpatcern
Copy link
Member

@grgprarup could you please rebase? it seems some conflicts got in the way meanwhile.

@phil-davis
Copy link
Contributor

PR #3629 changed the CI also.

@grgprarup please rebase and sort out what changes actually are still needed here.

@grgprarup grgprarup dismissed stale reviews from glpatcern, vascoguita, and phil-davis via 0d5f2d9 January 27, 2023 03:32
@grgprarup grgprarup force-pushed the remove-unused-make-target branch from 14a2d5b to 0d5f2d9 Compare January 27, 2023 03:32
@grgprarup grgprarup requested review from glpatcern and phil-davis and removed request for glpatcern January 27, 2023 03:49
@phil-davis phil-davis requested a review from vascoguita January 27, 2023 03:51
phil-davis
phil-davis previously approved these changes Jan 27, 2023
@phil-davis phil-davis requested a review from glpatcern January 27, 2023 03:53
@phil-davis
Copy link
Contributor

@labkode @gmgigi96 @glpatcern there used to be code in the drone changelog check that would skip the check when we put tests-only in the PR title. Is there a way to implement something like that in the new "Check Changelog" workflow?

@phil-davis phil-davis self-requested a review January 27, 2023 04:06
@phil-davis
Copy link
Contributor

@labkode @gmgigi96 @glpatcern ready for review again.

@phil-davis phil-davis self-assigned this Jan 27, 2023
@glpatcern glpatcern merged commit 6ad4a2b into cs3org:master Jan 27, 2023
@phil-davis phil-davis deleted the remove-unused-make-target branch January 27, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA] Sort out test-acceptance-core-api in cs3org/reva
4 participants