New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[settings] Do not use v-model and input event for the same component #5257

Merged

dschmidt merged 1 commit into master from do-not-use-v-model-and-input-event

Dec 20, 2022

Member

dschmidt commented Dec 20, 2022

Description

Related Issue

Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

test environment:
test case 1:
test case 2:
...

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)

Checklist:

Code changes
Unit tests added
Acceptance tests added
Documentation ticket raised:


          [settings] Do not use v-model and input event for the same component

5ccefa3

dschmidt requested review from kulmann and lookacat as code owners

December 20, 2022 13:38

update-docs bot commented Dec 20, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

sonarqubecloud bot commented Dec 20, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

fschade approved these changes

View reviewed changes

Contributor

fschade left a comment

LGTM

dschmidt merged commit 9131bdb into master

delete-merged-branch bot deleted the do-not-use-v-model-and-input-event branch

December 20, 2022 14:12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet