Merge pull request #5257 from owncloud/do-not-use-v-model-and-input-e…

…vent [settings] Do not use v-model and input event for the same component
owncloud · Dec 20, 2022 · 9131bdb · 9131bdb
2 parents f44f50b + 5ccefa3
commit 9131bdb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/services/settings/ui/components/settings/SettingMultiChoice.vue b/services/settings/ui/components/settings/SettingMultiChoice.vue
@@ -1,8 +1,8 @@
 <template>
   <oc-select
-      v-model="selectedOptions"
       :clearable="false"
       :options="displayOptions"
+      :value="selectedOptions"
       @input="onSelectedOption"
       multiple
   />
@@ -37,7 +37,8 @@ export default {
     }
   },
   methods: {
-    async onSelectedOption () {
+    async onSelectedOption (event) {
+      this.selectedOptions = event
       const values = []
       if (!isNil(this.selectedOptions)) {
         this.selectedOptions.forEach(displayValue => {

diff --git a/services/settings/ui/components/settings/SettingSingleChoice.vue b/services/settings/ui/components/settings/SettingSingleChoice.vue
@@ -1,9 +1,9 @@
 <template>
   <div>
     <oc-select
-        v-model="selectedOption"
         :clearable="false"
         :options="displayOptions"
+        :value="selectedOption"
         @input="onSelectedOption"
        />
   </div>
@@ -38,7 +38,8 @@ export default {
     }
   },
   methods: {
-    async onSelectedOption () {
+    async onSelectedOption (event) {
+      this.selectedOption = event
       const values = []
       if (!isNil(this.selectedOption)) {
         const option = this.setting.singleChoiceValue.options.find(val => val.displayValue === this.selectedOption)