Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] update Reva to latest edge #4522

Merged
merged 3 commits into from
Sep 7, 2022
Merged

[full-ci] update Reva to latest edge #4522

merged 3 commits into from
Sep 7, 2022

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Sep 6, 2022

Description

Update reva to latest edge.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/15243/41/7
various scenarios that expect "out of quota" 507 status are failing.

@micbar
Copy link
Contributor Author

micbar commented Sep 6, 2022

@butonic @C0rby Seems that we broke some quota handling stuff.

@grgprarup grgprarup mentioned this pull request Sep 7, 2022
Closed
@micbar micbar force-pushed the update-reva-edge branch 2 times, most recently from d1ac7b7 to b2dd806 Compare September 7, 2022 11:01
@micbar micbar mentioned this pull request Sep 7, 2022
Closed
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@micbar
Copy link
Contributor Author

micbar commented Sep 7, 2022

@ScharfViktor I changed the space deletion logic in the GraphHelper.

@micbar
Copy link
Contributor Author

micbar commented Sep 7, 2022

Project spaces cannot be deleted atm, needs the next improvement cs3org/reva#3203

@ScharfViktor
Copy link
Contributor

Regarding deleting personal space: I will change it-> after each test the admin will delete all created users (personal space is deleted automatically). PR is ready

@micbar micbar merged commit 29be1ab into master Sep 7, 2022
@delete-merged-branch delete-merged-branch bot deleted the update-reva-edge branch September 7, 2022 17:03
ownclouders pushed a commit that referenced this pull request Sep 7, 2022
@micbar
commit 29be1ab
1e04c60 
Merge: c982bd7 869d8ab
Author: Michael Barz <[email protected]>
Date:   Wed Sep 7 19:03:35 2022 +0200

    Merge pull request #4522 from owncloud/update-reva-edge

    [full-ci] update Reva to latest edge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@kulmann kulmann kulmann approved these changes

@butonic butonic butonic approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@micbar @phil-davis @ScharfViktor @butonic @kulmann @kobergj