Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "delete-all-spaces" permission check #3203

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Conversation

rhafer
Copy link
Contributor

@rhafer rhafer commented Sep 7, 2022

We introduced a new permission "delete-all-spaces", users holding this permission are allowed to delete any space of any type.

@rhafer rhafer self-assigned this Sep 7, 2022
We introduced a new permission "delete-all-spaces", users holding this permission are allowed
to delete any space of any type.
@rhafer rhafer marked this pull request as ready for review September 7, 2022 14:49
@rhafer rhafer requested review from a team, labkode, ishank011 and glpatcern as code owners September 7, 2022 14:49
Copy link
Contributor

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considering the critically it's good to go

changelog/unreleased/delete-all-spaces-perm.md Outdated Show resolved Hide resolved
pkg/storage/utils/decomposedfs/spaces.go Outdated Show resolved Hide resolved
pkg/storage/utils/decomposedfs/spaces.go Outdated Show resolved Hide resolved
@rhafer rhafer merged commit fcb7745 into cs3org:edge Sep 7, 2022
@micbar micbar mentioned this pull request Sep 12, 2022
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants