Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Add Tests for creating Files and Folder When Space Shares Jail exists for core PR 40239 #4284

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Jul 26, 2022

Description

All the tests related to the Shares folder from core is to be implemented in ocis. This PR adds tests to create files and folders when space Shares Jail exists. Since Shares folder is not created on OCIS like as in core. Those Tests are shifted here.

Related issue

#4154
#3033

Dependent Issue

owncloud/core#40239

I have not updated the expected to failure command. see this comment #3033 (comment)

@SagarGi SagarGi self-assigned this Jul 26, 2022
@SagarGi SagarGi force-pushed the addTestToCreateFilesFolderIFSharesExists branch from 33b69eb to 4d9044c Compare July 27, 2022 04:01
@SagarGi SagarGi marked this pull request as ready for review July 27, 2022 04:07
@SagarGi SagarGi force-pushed the addTestToCreateFilesFolderIFSharesExists branch from 4d9044c to 069df67 Compare July 27, 2022 04:14
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SagarGi SagarGi requested review from SwikritiT and phil-davis July 27, 2022 08:05
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis phil-davis merged commit fd58035 into master Jul 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the addTestToCreateFilesFolderIFSharesExists branch July 27, 2022 08:40
ownclouders pushed a commit that referenced this pull request Jul 27, 2022
Merge: d3f70e4 37e9a62
Author: Phil Davis <[email protected]>
Date:   Wed Jul 27 14:25:42 2022 +0545

    Merge pull request #4284 from owncloud/addTestToCreateFilesFolderIFSharesExists

    [tests-only][full-ci]Add Tests for creating Files and Folder When Space Shares Jail exists for core PR 40239
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants