Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci]Remove /Shares related scenarios from core #40239

Merged
merged 1 commit into from
Jul 26, 2022
Merged

[tests-only][full-ci]Remove /Shares related scenarios from core #40239

merged 1 commit into from
Jul 26, 2022

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Jul 26, 2022 •
edited
Loading

Description

These scenarios always fails since in core Shares related code is not implemented. So these scenarios can be implemented rather in ocis and can be removed from expected to failure.

Related Issue

owncloud/ocis#4154
owncloud/ocis#3033

Motivation and Context

How Has This Been Tested?

  • test environment:
  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@SagarGi SagarGi self-assigned this Jul 26, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SagarGi SagarGi mentioned this pull request Jul 26, 2022
Merged
@SagarGi SagarGi marked this pull request as ready for review July 26, 2022 09:43
kiranparajuli589
kiranparajuli589 reviewed Jul 26, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@phil-davis phil-davis merged commit bc4cb57 into master Jul 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the removeSharesSpaceRelatedFromCore branch July 26, 2022 11:08
@SagarGi SagarGi restored the removeSharesSpaceRelatedFromCore branch July 27, 2022 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@phil-davis phil-davis phil-davis approved these changes

@saw-jan saw-jan Awaiting requested review from saw-jan

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

Assignees

@SagarGi SagarGi

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SagarGi @phil-davis @kiranparajuli589