Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Add tests removed by core 40226 #4258

Merged
merged 2 commits into from
Jul 26, 2022
Merged

[tests-only] Add tests removed by core 40226 #4258

merged 2 commits into from
Jul 26, 2022

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Jul 22, 2022 •
edited
Loading

Description

This PR adds tests removed by : owncloud/core#40226
And bumps commit id: owncloud/QA#753

Related Issue

Part of: #4154
owncloud/QA#753

Motivation and Context

How Has This Been Tested?

  • local
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@SwikritiT SwikritiT mentioned this pull request Jul 22, 2022
Merged
6 tasks
@SwikritiT SwikritiT self-assigned this Jul 22, 2022
@SwikritiT SwikritiT force-pushed the add-tests-removed-by-core-40226 branch from 3350329 to 969e1be Compare July 22, 2022 10:09
@ownclouders
Copy link
Contributor

💥 Acceptance test Core-API-Tests-ocis-storage-8 failed. Further test are cancelled...

@SwikritiT SwikritiT force-pushed the add-tests-removed-by-core-40226 branch 2 times, most recently from 01d664c to 6987608 Compare July 25, 2022 06:56
@SwikritiT SwikritiT marked this pull request as ready for review July 25, 2022 08:16
@SwikritiT SwikritiT mentioned this pull request Jul 25, 2022
Closed
14 tasks
kiranparajuli589
kiranparajuli589 reviewed Jul 25, 2022
View reviewed changes
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm 👍

tests/acceptance/features/apiSpaces/etagPropagation.feature Outdated Show resolved Hide resolved
SagarGi
SagarGi reviewed Jul 26, 2022
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@SwikritiT SwikritiT force-pushed the add-tests-removed-by-core-40226 branch from 6987608 to b83dfe9 Compare July 26, 2022 04:10
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 0eb8d4d into master Jul 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the add-tests-removed-by-core-40226 branch July 26, 2022 05:35
ownclouders pushed a commit that referenced this pull request Jul 26, 2022
@phil-davis
commit 0eb8d4d
a1e75b6 
Merge: 1d94502 b83dfe9
Author: Phil Davis <[email protected]>
Date:   Tue Jul 26 11:20:23 2022 +0545

    Merge pull request #4258 from owncloud/add-tests-removed-by-core-40226

    [tests-only] Add tests removed by core 40226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi left review comments

@kiranparajuli589 kiranparajuli589 kiranparajuli589 left review comments

@phil-davis phil-davis phil-davis approved these changes

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@grgprarup grgprarup Awaiting requested review from grgprarup

@saw-jan saw-jan Awaiting requested review from saw-jan

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SwikritiT @ownclouders @phil-davis @kiranparajuli589 @SagarGi