Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Skip Shares folder including eTag propagation scenarios for space DAV version #40226

Merged
merged 2 commits into from
Jul 25, 2022
Merged

[tests-only] Skip Shares folder including eTag propagation scenarios for space DAV version #40226

merged 2 commits into from
Jul 25, 2022

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Jul 21, 2022 •
edited
Loading

Signed-off-by: Kiran Parajuli [email protected]

Description

Shares is not a folder to grab an eTag from. We've to grab eTag from resources within Shares spaces.
With this PR, removing all scenarios including Shares for spaces DAV version

Related Issue

Motivation and Context

How Has This Been Tested?

  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@kiranparajuli589
Copy link
Contributor Author

kiranparajuli589 commented Jul 21, 2022 •
edited by SwikritiT
Loading

TODO:

@kiranparajuli589 kiranparajuli589 self-assigned this Jul 22, 2022
SwikritiT
SwikritiT reviewed Jul 22, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SwikritiT SwikritiT mentioned this pull request Jul 22, 2022
Merged
9 tasks
@kiranparajuli589
Fix scenario title
bb2d81b 
Signed-off-by: Kiran Parajuli <[email protected]>
SwikritiT
SwikritiT approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis phil-davis merged commit 11d7107 into master Jul 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the skip-more-shares-folder-including-etag-prop-tests branch July 25, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT approved these changes

@phil-davis phil-davis phil-davis approved these changes

Assignees

@kiranparajuli589 kiranparajuli589

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kiranparajuli589 @phil-davis @SwikritiT