Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove composition of Commons #3803

Merged
merged 1 commit into from
May 16, 2022
Merged

remove composition of Commons #3803

merged 1 commit into from
May 16, 2022

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented May 16, 2022

Description

Removes the composition of the Commons config, since it is not used and confusing to devs and produces undesirable IDE autocompletion.

Commons should only be used:

  • in ./ocis or ./ocis-pkg to copy common configuration into the Commons struct
  • in ./extensions/xxx to copy configuration out of the Commons struct

Related Issue

Motivation and Context

Removes undesired IDE autocompletion

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented May 16, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek marked this pull request as ready for review May 16, 2022 09:34
@wkloucek wkloucek requested review from butonic, dragonchaser, kobergj and rhafer and removed request for kulmann and pascalwengerter May 16, 2022 09:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micbar micbar merged commit 6a7fc50 into owncloud:master May 16, 2022
ownclouders pushed a commit that referenced this pull request May 16, 2022
Merge: 4a02fd8 3ce2c21
Author: Michael Barz <[email protected]>
Date:   Mon May 16 12:13:44 2022 +0200

    Merge pull request #3803 from wkloucek/un-compose-commons

    remove composition of Commons
@wkloucek wkloucek deleted the un-compose-commons branch May 16, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants